cleaning up elisp byte compiler warnings

5 files changed, 27 insertions, 11 deletions

diff --git a/lisp/ledger-complete.el b/lisp/ledger-complete.el
index 1a4fbd48..8c772b4b 100644
--- a/lisp/ledger-complete.el
+++ b/lisp/ledger-complete.el
@@ -24,11 +24,14 @@
 
 (require 'pcomplete)
 
-(declare-function ledger-thing-at-point "ledger-context" nil)
 ;; In-place completion support
 
 ;;; Code:
 
+(declare-function ledger-thing-at-point "ledger-context" nil)
+(declare-function ledger-add-transaction "ledger-xact" (transaction-text &optional insert-at-point))
+(declare-function between "ledger-schedule" (val low high))
+
 (defun ledger-parse-arguments ()
   "Parse whitespace separated arguments in the current region."
   ;; this is more complex than it appears to need, so that it can work
diff --git a/lisp/ledger-report.el b/lisp/ledger-report.el
index a8ed9060..0eb0e4a0 100644
--- a/lisp/ledger-report.el
+++ b/lisp/ledger-report.el
@@ -25,6 +25,11 @@
 
 ;;; Code:
 
+(declare-function ledger-read-string-with-default "ledger-mode" (prompt default))
+(declare-function ledger-xact-payee "ledger-xact" nil)
+(declare-function ledger-read-account-with-prompt "ledger-mode" (prompt))
+(declare-function ledger-navigate-to-line "ledger-navigate" (line-number))
+
 (require 'easymenu)
 (eval-when-compile
   (require 'cl))
@@ -151,13 +156,13 @@ text that should replace the format specifier."
   "A mode for viewing ledger reports.")
 
 (defun ledger-report-tagname-format-specifier ()
-  "Return a valid meta-data tag name"
+  "Return a valid meta-data tag name."
   ;; It is intended completion should be available on existing account
   ;; names, but it remains to be implemented.
   (ledger-read-string-with-default "Tag Name: " nil))
 
 (defun ledger-report-tagvalue-format-specifier ()
-  "Return a valid meta-data tag name"
+  "Return a valid meta-data tag name."
   ;; It is intended completion should be available on existing account
   ;; names, but it remains to be implemented.
   (ledger-read-string-with-default "Tag Value: " nil))
@@ -420,8 +425,8 @@ Optional EDIT the command."
   (customize-variable 'ledger-reports))
 
 (defun ledger-report-edit-report ()
+	"Edit the current report command in the mini buffer and re-run the report."
 	(interactive)
-	"Edit the current report command in the mini buffer and re-run the report"
 	(setq ledger-report-cmd (ledger-report-read-command ledger-report-cmd))
 	(ledger-report-redo))
 
diff --git a/lisp/ledger-sort.el b/lisp/ledger-sort.el
index 870e298c..a8f0a0bd 100644
--- a/lisp/ledger-sort.el
+++ b/lisp/ledger-sort.el
@@ -25,20 +25,22 @@
 ;;
 
 ;;; Code:
-
+(defvar ledger-payee-any-status-regex)
+(declare-function ledger-navigate-find-xact-extents "ledger-navigate" (pos))
+(declare-function ledger-navigate-next-xact "ledger-navigate" nil)
 
 (defun ledger-sort-find-start ()
-	"Find the beginning of a sort region"
+	"Find the beginning of a sort region."
   (if (re-search-forward ";.*Ledger-mode:.*Start sort" nil t)
       (match-end 0)))
 
 (defun ledger-sort-find-end ()
-	"Find the end of a sort region"
+	"Find the end of a sort region."
   (if (re-search-forward ";.*Ledger-mode:.*End sort" nil t)
       (match-end 0)))
 
 (defun ledger-sort-insert-start-mark ()
-	"Insert a marker to start a sort region"
+	"Insert a marker to start a sort region."
   (interactive)
   (save-excursion
     (goto-char (point-min))
@@ -48,7 +50,7 @@
   (insert "\n; Ledger-mode: Start sort\n\n"))
 
 (defun ledger-sort-insert-end-mark ()
-	"Insert a marker to end a sort region"
+	"Insert a marker to end a sort region."
   (interactive)
   (save-excursion
     (goto-char (point-min))
@@ -58,7 +60,7 @@
   (insert "\n; Ledger-mode: End sort\n\n"))
 
 (defun ledger-sort-startkey ()
-  "Return the actual date so the sort-subr doesn't sort onthe entire first line."
+  "Return the actual date so the sort subroutine doesn't sort on the entire first line."
   (buffer-substring-no-properties (point) (+ 10 (point))))
 
 (defun ledger-sort-region (beg end)
diff --git a/lisp/ledger-state.el b/lisp/ledger-state.el
index 47805f15..1bc5974d 100644
--- a/lisp/ledger-state.el
+++ b/lisp/ledger-state.el
@@ -24,6 +24,8 @@
 ;; Utilities for dealing with transaction and posting status.
 
 ;;; Code:
+(declare-function ledger-navigate-find-xact-extents "ledger-navigate" (pos))
+(declare-function ledger-thing-at-point "ledger-context" ())
 
 (defcustom ledger-clear-whole-transactions nil
   "If non-nil, clear whole transactions, not individual postings."
@@ -67,7 +69,7 @@
 
 
 (defun ledger-state-from-string (state-string)
-  "Get state from STATE-CHAR."
+  "Get state from STATE-STRING."
   (when state-string
     (cond
      ((string-match "\\!" state-string) 'pending)
diff --git a/lisp/ledger-xact.el b/lisp/ledger-xact.el
index bad36e7a..8e89d714 100644
--- a/lisp/ledger-xact.el
+++ b/lisp/ledger-xact.el
@@ -28,6 +28,10 @@
 (require 'eshell)
 (require 'ledger-regex)
 (require 'ledger-navigate)
+
+(defvar ledger-year)
+(defvar ledger-month)
+
 ;; TODO: This file depends on code in ledger-mode.el, which depends on this.
 
 (defcustom ledger-highlight-xact-under-point t