diff options
author | Sam Clegg <sbc@chromium.org> | 2020-05-04 14:08:43 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-05-04 11:08:43 -0700 |
commit | c0eb93567e278fe86a6fd8fb0002db5984db1a84 (patch) | |
tree | dca3011605f5e5dedadb0998fe69016a352ba73f /.github/workflows/ci.yml | |
parent | e093d14f85ef3b6fd2e7172ef3f548deb8003305 (diff) | |
download | binaryen-c0eb93567e278fe86a6fd8fb0002db5984db1a84.tar.gz binaryen-c0eb93567e278fe86a6fd8fb0002db5984db1a84.tar.bz2 binaryen-c0eb93567e278fe86a6fd8fb0002db5984db1a84.zip |
CI: Use stripped release builds for distribution (#2826)
Even though `Release` is the default configuration for make better
to be explicit.
Also, for windows build we need to make sure we pass `--config Release`
when actually building since the projects files will build Debug by
default regardless of CMAKE_BUILD_TYPE.
Fixes: #2825
Diffstat (limited to '.github/workflows/ci.yml')
-rw-r--r-- | .github/workflows/ci.yml | 22 |
1 files changed, 16 insertions, 6 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 319b08fad..05d080be9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -62,11 +62,11 @@ jobs: run: mkdir -p out - name: cmake (linux) - run: cmake -S . -B out -G Ninja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ + run: cmake -S . -B out -G Ninja -DCMAKE_BUILD_TYPE=Release if: matrix.os == 'ubuntu-latest' - name: cmake (osx) - run: cmake -S . -B out -G Ninja + run: cmake -S . -B out -G Ninja -DCMAKE_BUILD_TYPE=Release if: matrix.os == 'macos-latest' - name: cmake (win) @@ -75,7 +75,11 @@ jobs: if: matrix.os == 'windows-latest' - name: build - run: cmake --build out + run: cmake --build out --config Release + + - name: strip + run: find out/bin/ -type f -perm -u=x -exec strip {} + + if: matrix.os != 'windows-latest' - name: test run: python check.py --binaryen-bin=out/bin @@ -83,8 +87,14 @@ jobs: # https://github.com/WebAssembly/binaryen/issues/2781 if: matrix.os != 'windows-latest' - build-gcc: - name: gcc + - name: Upload artifacts + uses: actions/upload-artifact@v1 + with: + name: build-${{ matrix.os }} + path: out/bin + + build-clang: + name: clang runs-on: ubuntu-latest steps: - uses: actions/setup-python@v1 @@ -96,7 +106,7 @@ jobs: - name: cmake run: | mkdir -p out - cmake -S . -B out -G Ninja -DCMAKE_C_COMPILER=gcc-7 -DCMAKE_CXX_COMPILER=g++-7 + cmake -S . -B out -G Ninja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ - name: build run: cmake --build out - name: test |