diff options
| author | Sam Clegg <sbc@chromium.org> | 2020-04-21 18:10:54 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-21 15:10:54 -0700 |
| commit | 086bee68e4f4bef146970f8dc6740356473c8bed (patch) | |
| tree | 1e0719d5d896f8a802a51a51bdafb8512379ffb5 | |
| parent | 8e017e9fe58687251275d6fe8a1a0b23813c3b1e (diff) | |
| download | binaryen-086bee68e4f4bef146970f8dc6740356473c8bed.tar.gz binaryen-086bee68e4f4bef146970f8dc6740356473c8bed.tar.bz2 binaryen-086bee68e4f4bef146970f8dc6740356473c8bed.zip | |
CI: clang-tidy requires cmake to have been run (#2783)
I somehow missed this the transition to github actions.
Also the I forgot to include the gen-s-parser test.
| -rw-r--r-- | .github/workflows/ci.yml | 27 |
1 files changed, 8 insertions, 19 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 706ada62e..e96860323 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,17 +17,20 @@ jobs: with: python-version: '3.x' - uses: actions/checkout@v1 - with: - submodules: true - name: install tools run: | sudo pip3 install flake8==3.7.8 sudo apt-get install clang-format clang-tidy echo "::add-path::/usr/lib/llvm-8/bin" - - name: flake8 - run: flake8 + - run: flake8 - run: ./scripts/clang-format-diff.sh - - run: ./scripts/clang-tidy-diff.sh + - name: clang-tidy + run: | + # clang-tidy requires compile_commands.json generated by cmake + cmake . -DCMAKE_EXPORT_COMPILE_COMMANDS=ON + ./scripts/clang-tidy-diff.sh + - name: gen-s-parser + run: ./scripts/gen-s-parser.py | diff src/gen-s-parser.inc - build: name: build @@ -40,8 +43,6 @@ jobs: with: python-version: '3.x' - uses: actions/checkout@v1 - with: - submodules: true - name: install ninja (linux) run: sudo apt-get install ninja-build @@ -90,8 +91,6 @@ jobs: with: python-version: '3.x' - uses: actions/checkout@v1 - with: - submodules: true - name: start docker run: | docker run -w /src -dit --name alpine -v $PWD:/src node:lts-alpine @@ -116,8 +115,6 @@ jobs: with: python-version: '3.x' - uses: actions/checkout@v1 - with: - submodules: true - name: install ninja run: sudo apt-get install ninja-build - name: cmake @@ -142,8 +139,6 @@ jobs: with: python-version: '3.x' - uses: actions/checkout@v1 - with: - submodules: true - name: install ninja run: sudo apt-get install ninja-build - name: cmake @@ -168,8 +163,6 @@ jobs: with: python-version: '3.x' - uses: actions/checkout@v1 - with: - submodules: true - name: install ninja run: sudo apt-get install ninja-build - name: cmake @@ -193,8 +186,6 @@ jobs: with: python-version: '3.x' - uses: actions/checkout@v1 - with: - submodules: true - name: install ninja run: sudo apt-get install ninja-build - name: cmake @@ -215,8 +206,6 @@ jobs: with: python-version: '3.x' - uses: actions/checkout@v1 - with: - submodules: true - name: install ninja run: sudo apt-get install ninja-build - name: download cmake |