summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlon Zakai <azakai@google.com>2023-10-17 11:59:10 -0700
committerGitHub <noreply@github.com>2023-10-17 11:59:10 -0700
commit1d73da109190ceaa29659f4986c8db81d2592d16 (patch)
treeb9ebb1011ba75889c35217dbdb64e2b677bea717
parentde81d7dac836b9c6f02526709cda39ba27a81d88 (diff)
downloadbinaryen-1d73da109190ceaa29659f4986c8db81d2592d16.tar.gz
binaryen-1d73da109190ceaa29659f4986c8db81d2592d16.tar.bz2
binaryen-1d73da109190ceaa29659f4986c8db81d2592d16.zip
[NFC] Some misc comments for clarification (#6017)
-rw-r--r--src/binaryen-c.h2
-rw-r--r--test/lit/passes/cfp.wast6
2 files changed, 6 insertions, 2 deletions
diff --git a/src/binaryen-c.h b/src/binaryen-c.h
index d16f46d9a..ee56afdad 100644
--- a/src/binaryen-c.h
+++ b/src/binaryen-c.h
@@ -1051,6 +1051,8 @@ BINARYEN_API BinaryenExpressionRef BinaryenBrOn(BinaryenModuleRef module,
const char* name,
BinaryenExpressionRef ref,
BinaryenType castType);
+// Passing in null for |operands| (and 0 for |numOperands|) implies this is
+// struct.new_default.
BINARYEN_API BinaryenExpressionRef
BinaryenStructNew(BinaryenModuleRef module,
BinaryenExpressionRef* operands,
diff --git a/test/lit/passes/cfp.wast b/test/lit/passes/cfp.wast
index 38e17c578..b61f2c6a6 100644
--- a/test/lit/passes/cfp.wast
+++ b/test/lit/passes/cfp.wast
@@ -2497,7 +2497,8 @@
(local.get $B1)
)
)
- ;; The copy can't refer to a $B2, so we can optimize here. TODO
+ ;; The copy can't refer to a $B2, so we can optimize here. TODO (but GUFA
+ ;; can do this)
(drop
(struct.get $B2 0
(local.get $B2)
@@ -2602,7 +2603,8 @@
(local.get $A)
)
)
- ;; The copy can't refer to a $B1, so we can optimize here. TODO
+ ;; The copy can't refer to a $B1, so we can optimize here. TODO (but GUFA
+ ;; can do this)
(drop
(struct.get $B1 0
(local.get $B1)