diff options
| author | Thomas Lively <tlively@google.com> | 2024-12-16 12:05:09 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-16 20:05:09 +0000 |
| commit | 315f7c1f65d67d2d8e008c6973354abac80d8d22 (patch) | |
| tree | 399e9e465983644589fcfdf65ec9febbafb227ec | |
| parent | 0272a2745a27ceb5839e933cbb371e33b3d7244d (diff) | |
| download | binaryen-315f7c1f65d67d2d8e008c6973354abac80d8d22.tar.gz binaryen-315f7c1f65d67d2d8e008c6973354abac80d8d22.tar.bz2 binaryen-315f7c1f65d67d2d8e008c6973354abac80d8d22.zip | |
Enable upstream spec tests requiring block parameters (#7151)
Now that #7149 added support for parsing block parameters, we can run
additional spec tests that previously failed.
| -rw-r--r-- | CHANGELOG.md | 2 | ||||
| -rw-r--r-- | scripts/test/shared.py | 6 | ||||
| -rw-r--r-- | scripts/test/wasm2js.py | 1 |
3 files changed, 3 insertions, 6 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index b6ceeb8da..bea2a14d1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,7 +18,7 @@ Current Trunk - BinaryenSelect no longer takes a type parameter. - AutoDrop APIs have been removed. - Binaryen now supports parsing control flow structures with parameter types by - lowering them away in the parsers.. + lowering them away in the parsers. v120 ---- diff --git a/scripts/test/shared.py b/scripts/test/shared.py index 624a2f19a..8797f50b2 100644 --- a/scripts/test/shared.py +++ b/scripts/test/shared.py @@ -416,7 +416,6 @@ SPEC_TESTSUITE_TESTS_TO_SKIP = [ 'address.wast', # 64-bit offset allowed by memory64 'align.wast', # Alignment bit 6 used by multi-memory 'binary.wast', # memory.grow reserved byte a LEB in multi-memory - 'block.wast', # Requires block parameters 'bulk.wast', # Requires table.init abbreviation with implicit table 'comments.wast', # Issue with carriage returns being treated as newlines 'const.wast', # Hex float constant not recognized as out of range @@ -425,22 +424,19 @@ SPEC_TESTSUITE_TESTS_TO_SKIP = [ 'elem.wast', # Requires table.init abbreviation with implicit table 'f32.wast', # Adding -0 and -nan should give a canonical NaN 'f64.wast', # Adding -0 and -nan should give a canonical NaN - 'fac.wast', # Requires block parameters (on a loop) 'float_exprs.wast', # Adding 0 and NaN should give canonical NaN 'float_misc.wast', # Rounding wrong on f64.sqrt 'func.wast', # Duplicate parameter names not properly rejected 'global.wast', # Globals allowed to refer to previous globals by GC - 'if.wast', # Requires block parameters (on an if) + 'if.wast', # Requires more precise unreachable validation 'imports.wast', # Requires wast `register` support 'linking.wast', # Requires wast `register` support - 'loop.wast', # Requires block parameters (on a loop) 'memory.wast', # Multiple memories now allowed 'annotations.wast', # String annotations IDs should be allowed 'id.wast', # Empty IDs should be disallowed 'throw.wast', # Requires try_table interpretation 'try_catch.wast', # Requires wast `register` support 'tag.wast', # Non-empty tag results allowed by stack switching - 'throw_ref.wast', # Requires block parameters (on an if) 'try_table.wast', # Requires try_table interpretation 'br_on_non_null.wast', # Requires sending values on br_on_non_null 'br_on_null.wast', # Requires sending values on br_on_null diff --git a/scripts/test/wasm2js.py b/scripts/test/wasm2js.py index 95fe4fdac..3c70c0616 100644 --- a/scripts/test/wasm2js.py +++ b/scripts/test/wasm2js.py @@ -30,6 +30,7 @@ assert_tests = ['wasm2js.wast.asserts'] wasm2js_skipped_tests = [ 'empty_imported_table.wast', 'br.wast', # depends on multivalue + 'fac.wast', # depends on mutlivalue 'br_table.wast', # needs support for externref in assert_return ] |