summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Clegg <sbc@chromium.org>2018-11-30 14:09:35 -0800
committerGitHub <noreply@github.com>2018-11-30 14:09:35 -0800
commit33e337e5c141026505b114967a6bf0bf975e5dfc (patch)
treeedc38ac0437c50b5e8460f76b31c98c3f8a8e588
parent3814fd6f2dab5adb5fb81022308818e4dd3b1020 (diff)
downloadbinaryen-33e337e5c141026505b114967a6bf0bf975e5dfc.tar.gz
binaryen-33e337e5c141026505b114967a6bf0bf975e5dfc.tar.bz2
binaryen-33e337e5c141026505b114967a6bf0bf975e5dfc.zip
Add virtual destructor to fix build warning/error (#1793)
This error started showing up after: #1779 error: delete called on non-final 'wasm::ShellExternalInterface' that has virtual functions but non-virtual destructor
-rw-r--r--src/shell-interface.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/shell-interface.h b/src/shell-interface.h
index fbc0740c5..23f1c7de5 100644
--- a/src/shell-interface.h
+++ b/src/shell-interface.h
@@ -91,6 +91,7 @@ struct ShellExternalInterface : ModuleInstance::ExternalInterface {
std::vector<Name> table;
ShellExternalInterface() : memory() {}
+ virtual ~ShellExternalInterface() = default;
void init(Module& wasm, ModuleInstance& instance) override {
memory.resize(wasm.memory.initial * wasm::Memory::kPageSize);