use ensureFunctionType in s2wasm, to ensure consistent function type names

3 files changed, 22 insertions, 33 deletions

diff --git a/src/s2wasm.h b/src/s2wasm.h
index f4c83fe65..07262d012 100644
--- a/src/s2wasm.h
+++ b/src/s2wasm.h
@@ -752,16 +752,7 @@ class S2WasmBuilder {
           indirect->operands.push_back(inputs[i]);
         }
         setOutput(indirect, assign);
-        auto typeName = cashew::IString((std::string("FUNCSIG_") + getSig(indirect)).c_str(), false);
-        if (wasm.functionTypesMap.count(typeName) == 0) {
-          auto type = allocator.alloc<FunctionType>();
-          *type = sigToFunctionType(getSig(indirect));
-          type->name = typeName;
-          wasm.addFunctionType(type);
-          indirect->fullType = type;
-        } else {
-          indirect->fullType = wasm.functionTypesMap[typeName];
-        }
+        indirect->fullType = wasm.functionTypesMap[ensureFunctionType(getSig(indirect), &wasm, allocator)->name];
       } else {
         // non-indirect call
         CallBase* curr;
diff --git a/test/dot_s/bcp-1.wast b/test/dot_s/bcp-1.wast
index f558e06e0..76f1f49d4 100644
--- a/test/dot_s/bcp-1.wast
+++ b/test/dot_s/bcp-1.wast
@@ -9,8 +9,8 @@
     (segment 100 "\00\00\00\00")
   )
   (export "memory" memory)
-  (type $FUNCSIG_i (func (result i32)))
-  (type $FUNCSIG_ii (func (param i32) (result i32)))
+  (type $FUNCSIG$i (func (result i32)))
+  (type $FUNCSIG$ii (func (param i32) (result i32)))
   (type $FUNCSIG$vi (func (param i32)))
   (type $FUNCSIG$v (func))
   (import $exit "env" "exit" (param i32))
@@ -128,42 +128,42 @@
     )
     (block $label$0
       (br_if $label$0
-        (call_indirect $FUNCSIG_i
+        (call_indirect $FUNCSIG$i
           (i32.load offset=16
             (get_local $$0)
           )
         )
       )
       (br_if $label$0
-        (call_indirect $FUNCSIG_i
+        (call_indirect $FUNCSIG$i
           (i32.load offset=20
             (get_local $$0)
           )
         )
       )
       (br_if $label$0
-        (call_indirect $FUNCSIG_i
+        (call_indirect $FUNCSIG$i
           (i32.load offset=24
             (get_local $$0)
           )
         )
       )
       (br_if $label$0
-        (call_indirect $FUNCSIG_i
+        (call_indirect $FUNCSIG$i
           (i32.load offset=28
             (get_local $$0)
           )
         )
       )
       (br_if $label$0
-        (call_indirect $FUNCSIG_i
+        (call_indirect $FUNCSIG$i
           (i32.load offset=32
             (get_local $$0)
           )
         )
       )
       (br_if $label$0
-        (call_indirect $FUNCSIG_i
+        (call_indirect $FUNCSIG$i
           (i32.load offset=36
             (get_local $$0)
           )
@@ -179,13 +179,13 @@
       )
       (block $label$1
         (br_if $label$1
-          (call_indirect $FUNCSIG_ii
+          (call_indirect $FUNCSIG$ii
             (get_local $$1)
             (get_local $$2)
           )
         )
         (br_if $label$1
-          (call_indirect $FUNCSIG_ii
+          (call_indirect $FUNCSIG$ii
             (i32.load offset=44
               (get_local $$0)
             )
@@ -193,7 +193,7 @@
           )
         )
         (br_if $label$1
-          (call_indirect $FUNCSIG_ii
+          (call_indirect $FUNCSIG$ii
             (i32.load offset=48
               (get_local $$0)
             )
@@ -210,13 +210,13 @@
         )
         (block $label$2
           (br_if $label$2
-            (call_indirect $FUNCSIG_ii
+            (call_indirect $FUNCSIG$ii
               (get_local $$1)
               (get_local $$2)
             )
           )
           (br_if $label$2
-            (call_indirect $FUNCSIG_ii
+            (call_indirect $FUNCSIG$ii
               (i32.load offset=56
                 (get_local $$0)
               )
@@ -226,7 +226,7 @@
           (block $label$3
             (br_if $label$3
               (i32.eq
-                (call_indirect $FUNCSIG_i
+                (call_indirect $FUNCSIG$i
                   (i32.load offset=60
                     (get_local $$0)
                   )
@@ -236,7 +236,7 @@
             )
             (br_if $label$3
               (i32.eq
-                (call_indirect $FUNCSIG_i
+                (call_indirect $FUNCSIG$i
                   (i32.load offset=64
                     (get_local $$0)
                   )
@@ -246,7 +246,7 @@
             )
             (br_if $label$3
               (i32.eq
-                (call_indirect $FUNCSIG_i
+                (call_indirect $FUNCSIG$i
                   (i32.load offset=68
                     (get_local $$0)
                   )
@@ -257,7 +257,7 @@
             (block $label$4
               (br_if $label$4
                 (i32.eq
-                  (call_indirect $FUNCSIG_i
+                  (call_indirect $FUNCSIG$i
                     (i32.load offset=72
                       (get_local $$0)
                     )
@@ -267,7 +267,7 @@
               )
               (br_if $label$4
                 (i32.eq
-                  (call_indirect $FUNCSIG_i
+                  (call_indirect $FUNCSIG$i
                     (i32.load offset=76
                       (get_local $$0)
                     )
@@ -277,7 +277,7 @@
               )
               (br_if $label$4
                 (i32.eq
-                  (call_indirect $FUNCSIG_i
+                  (call_indirect $FUNCSIG$i
                     (i32.load offset=80
                       (get_local $$0)
                     )
diff --git a/test/llvm_autogenerated/call.wast b/test/llvm_autogenerated/call.wast
index cebd9dd6e..9f6c3dfb8 100644
--- a/test/llvm_autogenerated/call.wast
+++ b/test/llvm_autogenerated/call.wast
@@ -8,8 +8,6 @@
   (type $FUNCSIG$v (func))
   (type $FUNCSIG$ii (func (param i32) (result i32)))
   (type $FUNCSIG$iii (func (param i32 i32) (result i32)))
-  (type $FUNCSIG_v (func))
-  (type $FUNCSIG_i (func (result i32)))
   (import $i32_nullary "env" "i32_nullary" (result i32))
   (import $i64_nullary "env" "i64_nullary" (result i64))
   (import $float_nullary "env" "float_nullary" (result f32))
@@ -69,14 +67,14 @@
     )
   )
   (func $call_indirect_void (param $$0 i32)
-    (call_indirect $FUNCSIG_v
+    (call_indirect $FUNCSIG$v
       (get_local $$0)
     )
     (return)
   )
   (func $call_indirect_i32 (param $$0 i32) (result i32)
     (return
-      (call_indirect $FUNCSIG_i
+      (call_indirect $FUNCSIG$i
         (get_local $$0)
       )
     )