summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlon Zakai <alonzakai@gmail.com>2018-05-04 12:51:46 -0700
committerGitHub <noreply@github.com>2018-05-04 12:51:46 -0700
commit723cf52095fb98d0a34a0851683dbb17c9ec989f (patch)
tree221185c17a2b21688469efa56e127943eeac0c14
parente77743ee826ab3c2978711c856b1072ae97f6143 (diff)
downloadbinaryen-723cf52095fb98d0a34a0851683dbb17c9ec989f.tar.gz
binaryen-723cf52095fb98d0a34a0851683dbb17c9ec989f.tar.bz2
binaryen-723cf52095fb98d0a34a0851683dbb17c9ec989f.zip
misc minor cleanups in the codebase (#1531)
-rw-r--r--src/passes/ReorderLocals.cpp2
-rw-r--r--src/passes/SSAify.cpp2
-rw-r--r--test/binaryen.js/kitchen-sink.js2
3 files changed, 4 insertions, 2 deletions
diff --git a/src/passes/ReorderLocals.cpp b/src/passes/ReorderLocals.cpp
index c880714e6..fe4f775e9 100644
--- a/src/passes/ReorderLocals.cpp
+++ b/src/passes/ReorderLocals.cpp
@@ -19,6 +19,8 @@
//
// Secondarily, sort by first appearance. This canonicalizes the order.
//
+// While sorting, we remove locals that have no uses at all.
+//
#include <memory>
diff --git a/src/passes/SSAify.cpp b/src/passes/SSAify.cpp
index a6127e4d6..35432d9eb 100644
--- a/src/passes/SSAify.cpp
+++ b/src/passes/SSAify.cpp
@@ -40,7 +40,7 @@
namespace wasm {
// A set we know is impossible / not in the ast
-SetLocal IMPOSSIBLE_SET;
+static SetLocal IMPOSSIBLE_SET;
// Tracks assignments to locals, assuming single-assignment form, i.e.,
// each assignment creates a new variable.
diff --git a/test/binaryen.js/kitchen-sink.js b/test/binaryen.js/kitchen-sink.js
index 09828817a..c5f1f059a 100644
--- a/test/binaryen.js/kitchen-sink.js
+++ b/test/binaryen.js/kitchen-sink.js
@@ -501,7 +501,7 @@ function test_binaries() {
assert(size < 512); // this is a tiny module
// read the module from the binary
- module = Binaryen.readBinary(buffer, size);
+ module = Binaryen.readBinary(buffer);
// validate, print, and free
assert(module.validate());