diff options
| author | Thomas Lively <tlively@google.com> | 2022-11-17 17:08:21 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-17 17:08:21 -0800 |
| commit | 788cb172fb4081fc0f308458d737be7133b444d7 (patch) | |
| tree | 71871c5f2d6e4ec26cf921d255750a6f94bdda21 | |
| parent | 2218b63902cac62e02d9672034fc8d8415945973 (diff) | |
| download | binaryen-788cb172fb4081fc0f308458d737be7133b444d7.tar.gz binaryen-788cb172fb4081fc0f308458d737be7133b444d7.tar.bz2 binaryen-788cb172fb4081fc0f308458d737be7133b444d7.zip | |
Unpin V8 (#5277)
* Do not compare reference values across executions
Since we optimize assuming a closed world, optimizations can change the types
and structure of GC data even in externally-visible ways. Because differences
are expected, the fuzzer already did not compare reference-typed values from
before and after optimizations when running with nominal typing. Update it to
not compare these values under any type system.
* Unpin V8
Our WasmGC output is no longer compatible with the previously pinned version and
the issue that caused us to pin it in the first place has been resolved.
| -rw-r--r-- | scripts/test/shared.py | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/scripts/test/shared.py b/scripts/test/shared.py index eac4bd99d..1d48ddd68 100644 --- a/scripts/test/shared.py +++ b/scripts/test/shared.py @@ -202,9 +202,7 @@ NATIVEXX = (os.environ.get('CXX') or which('mingw32-g++') or NODEJS = os.getenv('NODE', which('node') or which('nodejs')) MOZJS = which('mozjs') or which('spidermonkey') -# TODO: Remove the specific v8 version once we implement structref and can run -# on recent v8. -V8 = which('v8-10.8.104') or which('v8') or which('d8') +V8 = which('v8') or which('d8') BINARYEN_INSTALL_DIR = os.path.dirname(options.binaryen_bin) WASM_OPT = [os.path.join(options.binaryen_bin, 'wasm-opt')] |