diff options
| author | Brendan Dahl <brendan.dahl@gmail.com> | 2024-10-03 16:34:29 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-03 23:34:29 +0000 |
| commit | 7f30b6c4c0af98642a8f22cbd4e61ff688f9e9fe (patch) | |
| tree | 497055a0a78f5305733cbc67e1cdc780410829fc | |
| parent | 36181c881c67f2b11386fdf885dbe33567db0d67 (diff) | |
| download | binaryen-7f30b6c4c0af98642a8f22cbd4e61ff688f9e9fe.tar.gz binaryen-7f30b6c4c0af98642a8f22cbd4e61ff688f9e9fe.tar.bz2 binaryen-7f30b6c4c0af98642a8f22cbd4e61ff688f9e9fe.zip | |
[FP16] Fix comment on f16x8.convert_i16x8_s test. (#6985)
0x7800 as FP16 is 32,768 not 32,767 as I had in the comment.
I also added another comment to explain the somewhat confusing behavior.
| -rw-r--r-- | test/spec/f16.wast | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/spec/f16.wast b/test/spec/f16.wast index b495fe2b6..60bcc74ba 100644 --- a/test/spec/f16.wast +++ b/test/spec/f16.wast @@ -238,9 +238,9 @@ (v128.const i16x8 0x5140 0x7e00 0x7c00 0xfc00 0x7bff 0xfbff 0 0)) (v128.const i16x8 42 0 65535 0 65504 0 0 0)) (assert_return (invoke "f16x8.convert_i16x8_s" - ;; + ;; 32767 is not representable as a whole integer in FP16, so it becomes 32768. (v128.const i16x8 0 1 -1 32767 -32768 0 0 0)) - ;; 0 1 -1 32767 -32768 0 0 0 + ;; 0 1 -1 32768 -32768 0 0 0 (v128.const i16x8 0 0x3c00 0xbc00 0x7800 0xf800 0 0 0)) (assert_return (invoke "f16x8.convert_i16x8_u" ;; Unlike f32/64, f16 can't represent the full 2^16 integer range so 2^16 becomes infinity. |