summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Lively <tlively@google.com>2022-10-19 13:39:21 -0500
committerGitHub <noreply@github.com>2022-10-19 13:39:21 -0500
commit829fa11c56d05335f441aab85953b4ef7ab56ba1 (patch)
tree6aac92fca4e0b8879fadb66abb02d386c90f5d68
parentc672ba43321e9631a0bebf9974a06fdb2df5bf7a (diff)
downloadbinaryen-829fa11c56d05335f441aab85953b4ef7ab56ba1.tar.gz
binaryen-829fa11c56d05335f441aab85953b4ef7ab56ba1.tar.bz2
binaryen-829fa11c56d05335f441aab85953b4ef7ab56ba1.zip
[NFC] Remove obsolete `makePush` functions (#5159)
`Push` expressions were removed in #2867, so we no longer need to make them.
-rw-r--r--src/wasm-s-parser.h1
-rw-r--r--src/wasm/wat-parser.cpp6
2 files changed, 0 insertions, 7 deletions
diff --git a/src/wasm-s-parser.h b/src/wasm-s-parser.h
index 74f0e05e2..a0edc4b7a 100644
--- a/src/wasm-s-parser.h
+++ b/src/wasm-s-parser.h
@@ -245,7 +245,6 @@ private:
Expression* makeDataDrop(Element& s);
Expression* makeMemoryCopy(Element& s);
Expression* makeMemoryFill(Element& s);
- Expression* makePush(Element& s);
Expression* makePop(Element& s);
Expression* makeIf(Element& s);
Expression* makeMaybeBlock(Element& s, size_t i, Type type);
diff --git a/src/wasm/wat-parser.cpp b/src/wasm/wat-parser.cpp
index 6fdffc33b..e05475517 100644
--- a/src/wasm/wat-parser.cpp
+++ b/src/wasm/wat-parser.cpp
@@ -1468,7 +1468,6 @@ template<typename Ctx> Result<typename Ctx::InstrT> makeMemoryInit(Ctx&, Index);
template<typename Ctx> Result<typename Ctx::InstrT> makeDataDrop(Ctx&, Index);
template<typename Ctx> Result<typename Ctx::InstrT> makeMemoryCopy(Ctx&, Index);
template<typename Ctx> Result<typename Ctx::InstrT> makeMemoryFill(Ctx&, Index);
-template<typename Ctx> Result<typename Ctx::InstrT> makePush(Ctx&, Index);
template<typename Ctx> Result<typename Ctx::InstrT> makePop(Ctx&, Index);
template<typename Ctx> Result<typename Ctx::InstrT> makeIf(Ctx&, Index);
template<typename Ctx>
@@ -2200,11 +2199,6 @@ Result<typename Ctx::InstrT> makeMemoryFill(Ctx& ctx, Index pos) {
}
template<typename Ctx>
-Result<typename Ctx::InstrT> makePush(Ctx& ctx, Index pos) {
- return ctx.in.err("unimplemented instruction");
-}
-
-template<typename Ctx>
Result<typename Ctx::InstrT> makePop(Ctx& ctx, Index pos) {
return ctx.in.err("unimplemented instruction");
}