diff options
| author | Alon Zakai <alonzakai@gmail.com> | 2015-12-22 12:51:02 -0800 |
|---|---|---|
| committer | Alon Zakai <alonzakai@gmail.com> | 2015-12-22 12:51:02 -0800 |
| commit | afd2e66106d08792f54aea7ddfa408853ce229ed (patch) | |
| tree | ff1cac7f33289af0c7056b23abe791e1a532d061 | |
| parent | bf680f7553433c2cd0ffdd641e4e37fceed8b7ed (diff) | |
| parent | 1749331c841d5ecc42d4b82617cb958766cbdfb6 (diff) | |
| download | binaryen-afd2e66106d08792f54aea7ddfa408853ce229ed.tar.gz binaryen-afd2e66106d08792f54aea7ddfa408853ce229ed.tar.bz2 binaryen-afd2e66106d08792f54aea7ddfa408853ce229ed.zip | |
Merge pull request #26 from WebAssembly/virtual-dtor
Add missing virtual dtor
| -rw-r--r-- | CMakeLists.txt | 2 | ||||
| -rw-r--r-- | src/pass.cpp | 2 | ||||
| -rw-r--r-- | src/wasm.h | 1 |
3 files changed, 3 insertions, 2 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 9fcd28066..72ec22970 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -7,7 +7,7 @@ SET(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/bin") SET(CMAKE_CXX_FLAGS "-std=c++11 ${CMAKE_CXX_FLAGS}") SET(CMAKE_CXX_FLAGS "-msse2 -mfpmath=sse ${CMAKE_CXX_FLAGS}") -SET(CMAKE_CXX_FLAGS "-O2 -Wall ${CMAKE_CXX_FLAGS}") +SET(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}") # clang doesn't print colored diagnostics when invoked from Ninja IF (UNIX AND diff --git a/src/pass.cpp b/src/pass.cpp index 63b1a7869..59f51df09 100644 --- a/src/pass.cpp +++ b/src/pass.cpp @@ -86,7 +86,7 @@ P* PassRunner::getLast() { PassRunner::~PassRunner() { for (auto pass : passes) { - delete(pass); + delete pass; } } diff --git a/src/wasm.h b/src/wasm.h index 8583f9492..9571c0e7e 100644 --- a/src/wasm.h +++ b/src/wasm.h @@ -1107,6 +1107,7 @@ private: template<class ReturnType> struct WasmVisitor { + virtual ~WasmVisitor() {} // should be pure virtual, but https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51048 // Expression visitors virtual ReturnType visitBlock(Block *curr) { abort(); } |