summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlon Zakai <azakai@google.com>2022-01-26 11:09:50 -0800
committerGitHub <noreply@github.com>2022-01-26 11:09:50 -0800
commitbf3386dbc804144dfb4b4d543da9fd53e2fcfc46 (patch)
treec7ce40f7518addbece4b8a66aa144413e9cdd6b2
parentcabe97319f146d72da26d9c3f7b41e920fa982de (diff)
downloadbinaryen-bf3386dbc804144dfb4b4d543da9fd53e2fcfc46.tar.gz
binaryen-bf3386dbc804144dfb4b4d543da9fd53e2fcfc46.tar.bz2
binaryen-bf3386dbc804144dfb4b4d543da9fd53e2fcfc46.zip
Remove old EffectAnalyzer hacks for asm.js debugInfo (#4457)
In asm2wasm we modelled debugInfo using special imports. And we tried to not move them around much. Current debugInfo is tracked on instructions and is not affected by removing this. This may have some tiny effect beneficial effect on code size in debug builds, perhaps.
-rw-r--r--src/ir/effects.h10
1 files changed, 1 insertions, 9 deletions
diff --git a/src/ir/effects.h b/src/ir/effects.h
index 2bce174ef..2bd209d3e 100644
--- a/src/ir/effects.h
+++ b/src/ir/effects.h
@@ -31,8 +31,7 @@ public:
Module& module,
Expression* ast = nullptr)
: ignoreImplicitTraps(passOptions.ignoreImplicitTraps),
- trapsNeverHappen(passOptions.trapsNeverHappen),
- debugInfo(passOptions.debugInfo), module(module),
+ trapsNeverHappen(passOptions.trapsNeverHappen), module(module),
features(module.features) {
if (ast) {
walk(ast);
@@ -41,7 +40,6 @@ public:
bool ignoreImplicitTraps;
bool trapsNeverHappen;
- bool debugInfo;
Module& module;
FeatureSet features;
@@ -433,12 +431,6 @@ private:
if (curr->isReturn) {
parent.branchesOut = true;
}
- if (parent.debugInfo) {
- // debugInfo call imports must be preserved very strongly, do not
- // move code around them
- // FIXME: we could check if the call is to an import
- parent.branchesOut = true;
- }
}
void visitCallIndirect(CallIndirect* curr) {
parent.calls = true;