diff options
| author | Sam Clegg <sbc@chromium.org> | 2022-02-01 11:07:06 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-01 19:07:06 +0000 |
| commit | c09ce3db9b938cf0cf1f0031f6bfd35aa1d81b3b (patch) | |
| tree | 9b3d3e7a58fdd95c32b670439ffb61afd700fe7c | |
| parent | c28f6cc1c93b282d1497e1e184ffba5efb782025 (diff) | |
| download | binaryen-c09ce3db9b938cf0cf1f0031f6bfd35aa1d81b3b.tar.gz binaryen-c09ce3db9b938cf0cf1f0031f6bfd35aa1d81b3b.tar.bz2 binaryen-c09ce3db9b938cf0cf1f0031f6bfd35aa1d81b3b.zip | |
Remove used wasm-emscripten-finalize option `--initial-stack-pointer` (#4490)
| -rw-r--r-- | src/tools/wasm-emscripten-finalize.cpp | 8 | ||||
| -rw-r--r-- | test/lit/help/wasm-emscripten-finalize.test | 3 |
2 files changed, 0 insertions, 11 deletions
diff --git a/src/tools/wasm-emscripten-finalize.cpp b/src/tools/wasm-emscripten-finalize.cpp index aa9d32213..8fdc203a9 100644 --- a/src/tools/wasm-emscripten-finalize.cpp +++ b/src/tools/wasm-emscripten-finalize.cpp @@ -110,14 +110,6 @@ int main(int argc, const char* argv[]) { [&globalBase](Options*, const std::string& argument) { globalBase = std::stoull(argument); }) - // TODO(sbc): Remove this one this argument is no longer passed by - // emscripten. See https://github.com/emscripten-core/emscripten/issues/8905 - .add("--initial-stack-pointer", - "", - "ignored - will be removed in a future release", - WasmEmscriptenFinalizeOption, - Options::Arguments::One, - [](Options*, const std::string& argument) {}) .add("--side-module", "", "Input is an emscripten side module", diff --git a/test/lit/help/wasm-emscripten-finalize.test b/test/lit/help/wasm-emscripten-finalize.test index 053179737..15ae1c176 100644 --- a/test/lit/help/wasm-emscripten-finalize.test +++ b/test/lit/help/wasm-emscripten-finalize.test @@ -26,9 +26,6 @@ ;; CHECK-NEXT: --global-base The address at which static globals were ;; CHECK-NEXT: placed ;; CHECK-NEXT: -;; CHECK-NEXT: --initial-stack-pointer ignored - will be removed in a future -;; CHECK-NEXT: release -;; CHECK-NEXT: ;; CHECK-NEXT: --side-module Input is an emscripten side module ;; CHECK-NEXT: ;; CHECK-NEXT: --input-source-map,-ism Consume source map from the specified |