summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlon Zakai <alonzakai@gmail.com>2016-08-07 10:37:15 -0700
committerAlon Zakai <alonzakai@gmail.com>2016-09-07 09:54:50 -0700
commitf9020a0bdb3912a65f3f051b3b841fad412d2f13 (patch)
treedcc6c715a2352b93b69ff2931a0e255c18705405
parentc846fb7dad4f18485979cf8c80c77bbb5d65c35f (diff)
downloadbinaryen-f9020a0bdb3912a65f3f051b3b841fad412d2f13.tar.gz
binaryen-f9020a0bdb3912a65f3f051b3b841fad412d2f13.tar.bz2
binaryen-f9020a0bdb3912a65f3f051b3b841fad412d2f13.zip
remove drop-return-values pass
-rw-r--r--src/passes/CMakeLists.txt1
-rw-r--r--src/passes/DropReturnValues.cpp83
-rw-r--r--src/passes/pass.cpp1
-rw-r--r--src/passes/passes.h1
4 files changed, 0 insertions, 86 deletions
diff --git a/src/passes/CMakeLists.txt b/src/passes/CMakeLists.txt
index 2ccf5f040..0baee7c3a 100644
--- a/src/passes/CMakeLists.txt
+++ b/src/passes/CMakeLists.txt
@@ -2,7 +2,6 @@ SET(passes_SOURCES
pass.cpp
CoalesceLocals.cpp
DeadCodeElimination.cpp
- DropReturnValues.cpp
DuplicateFunctionElimination.cpp
LowerIfElse.cpp
MergeBlocks.cpp
diff --git a/src/passes/DropReturnValues.cpp b/src/passes/DropReturnValues.cpp
deleted file mode 100644
index 8715f3f61..000000000
--- a/src/passes/DropReturnValues.cpp
+++ /dev/null
@@ -1,83 +0,0 @@
-/*
- * Copyright 2016 WebAssembly Community Group participants
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-//
-// Stops using return values from set_local and store nodes.
-//
-
-#include <wasm.h>
-#include <pass.h>
-#include <ast_utils.h>
-#include <wasm-builder.h>
-
-namespace wasm {
-
-struct DropReturnValues : public WalkerPass<PostWalker<DropReturnValues, Visitor<DropReturnValues>>> {
- bool isFunctionParallel() override { return true; }
-
- Pass* create() override { return new DropReturnValues; }
-
- std::vector<Expression*> expressionStack;
-
- void visitSetLocal(SetLocal* curr) {
- if (ExpressionAnalyzer::isResultUsed(expressionStack, getFunction())) {
- Builder builder(*getModule());
- replaceCurrent(builder.makeSequence(
- curr,
- builder.makeGetLocal(curr->index, curr->type)
- ));
- }
- }
-
- void visitStore(Store* curr) {
- if (ExpressionAnalyzer::isResultUsed(expressionStack, getFunction())) {
- Index index = getFunction()->getNumLocals();
- getFunction()->vars.emplace_back(curr->type);
- Builder builder(*getModule());
- replaceCurrent(builder.makeSequence(
- builder.makeSequence(
- builder.makeSetLocal(index, curr->value),
- curr
- ),
- builder.makeGetLocal(index, curr->type)
- ));
- curr->value = builder.makeGetLocal(index, curr->type);
- }
- }
-
- static void visitPre(DropReturnValues* self, Expression** currp) {
- self->expressionStack.push_back(*currp);
- }
-
- static void visitPost(DropReturnValues* self, Expression** currp) {
- self->expressionStack.pop_back();
- }
-
- static void scan(DropReturnValues* self, Expression** currp) {
- self->pushTask(visitPost, currp);
-
- WalkerPass<PostWalker<DropReturnValues, Visitor<DropReturnValues>>>::scan(self, currp);
-
- self->pushTask(visitPre, currp);
- }
-};
-
-Pass *createDropReturnValuesPass() {
- return new DropReturnValues();
-}
-
-} // namespace wasm
-
diff --git a/src/passes/pass.cpp b/src/passes/pass.cpp
index f27eccf6a..cd7e21542 100644
--- a/src/passes/pass.cpp
+++ b/src/passes/pass.cpp
@@ -64,7 +64,6 @@ void PassRegistry::registerPasses() {
registerPass("coalesce-locals", "reduce # of locals by coalescing", createCoalesceLocalsPass);
registerPass("coalesce-locals-learning", "reduce # of locals by coalescing and learning", createCoalesceLocalsWithLearningPass);
registerPass("dce", "removes unreachable code", createDeadCodeEliminationPass);
- registerPass("drop-return-values", "stops relying on return values from set_local and store", createDropReturnValuesPass);
registerPass("duplicate-function-elimination", "removes duplicate functions", createDuplicateFunctionEliminationPass);
registerPass("lower-if-else", "lowers if-elses into ifs, blocks and branches", createLowerIfElsePass);
registerPass("merge-blocks", "merges blocks to their parents", createMergeBlocksPass);
diff --git a/src/passes/passes.h b/src/passes/passes.h
index 731536d7d..4bb76edad 100644
--- a/src/passes/passes.h
+++ b/src/passes/passes.h
@@ -25,7 +25,6 @@ class Pass;
Pass *createCoalesceLocalsPass();
Pass *createCoalesceLocalsWithLearningPass();
Pass *createDeadCodeEliminationPass();
-Pass *createDropReturnValuesPass();
Pass *createDuplicateFunctionEliminationPass();
Pass *createLowerIfElsePass();
Pass *createMergeBlocksPass();