diff options
| author | Alon Zakai <azakai@google.com> | 2023-06-27 15:27:07 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-27 15:27:07 -0700 |
| commit | aaf1dac49865024fbde9d316c4a46345186217af (patch) | |
| tree | f8d2e0bcee1745492a602f8fb4aa1a9b9bd6d1e8 /CHANGELOG.md | |
| parent | fd9d04ccd615b185e65a765e3587eae3f72aa867 (diff) | |
| download | binaryen-aaf1dac49865024fbde9d316c4a46345186217af.tar.gz binaryen-aaf1dac49865024fbde9d316c4a46345186217af.tar.bz2 binaryen-aaf1dac49865024fbde9d316c4a46345186217af.zip | |
Fix opt/shrink levels when running the optimizer multiple times, Part 2 (#5787)
This is a followup to #5333 . That fixed the selection of which passes to run, but
forgot to also fix the global state of the current optimize/shrink levels. This PR
fixes that. As a result, running -O3 -Oz will now work as expected: the first -O3
will run the right passes (as #5333 fixed) and while running them, the global
optimize/shrinkLevels will be -O3 (and not -Oz), which this PR fixes.
A specific result of this is that -O3 -Oz used to inline less, since the invocation
of inlining during -O3 thought we were optimizing for size. The new test verifies
that we do fully inline in the first -O3 now.
Diffstat (limited to 'CHANGELOG.md')
| -rw-r--r-- | CHANGELOG.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index c416f16bf..beccb3e23 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,14 @@ full changeset diff at the end of each section. Current Trunk ------------- +- Fix a bug where e.g. -O3 -Oz ran the -O3 with the opt levels of -Oz, which + could inhibit inlining, for example. While this is a bugfix, it affects how + commandline options are interpreted, so if you depended on the old behavior + this may be a breaking change. That is, the old behavior made -O3 -Oz run the + first -O3 with -Oz's opt levels, and the new behavior is to run -O3 with the + proper (-O3) opt levels. This is a followup to #5333 from a previous release. + (#5787) + v113 ---- |