summaryrefslogtreecommitdiff
path: root/scripts/clang-tidy-diff.sh
diff options
context:
space:
mode:
authorAlon Zakai <azakai@google.com>2021-03-18 16:15:20 -0700
committerGitHub <noreply@github.com>2021-03-18 16:15:20 -0700
commit5575c13b1e8faef31e11ee0f009cd0f5d78b3e65 (patch)
tree987cc5218f5e653e920905873606bb8138ca152f /scripts/clang-tidy-diff.sh
parent26e6888d235645e993a9f870d597612412d28faf (diff)
downloadbinaryen-5575c13b1e8faef31e11ee0f009cd0f5d78b3e65.tar.gz
binaryen-5575c13b1e8faef31e11ee0f009cd0f5d78b3e65.tar.bz2
binaryen-5575c13b1e8faef31e11ee0f009cd0f5d78b3e65.zip
Revert the effect of #3689 (#3705)
That PR assumed that wasm-emscripten-finalize does not need to scan function bodies for metadata. But there is a case where it does, which is that EM_ASMs with pthreads do still require scanning of the code. So that approach is not valid. We could maybe disable the optimization just on pthreads, but I think major use cases need that. Also there is no simple way to disable it atm, we'd need changes on both emscripten and binaryen. Also that PR can no longer be reverted cleanly due to other changes. For all those reasons, this just disables the optimization so that users of tot are no longer broken, while we figure out how a valid way to optimize this use case.
Diffstat (limited to 'scripts/clang-tidy-diff.sh')
0 files changed, 0 insertions, 0 deletions