summaryrefslogtreecommitdiff
path: root/scripts/clang-tidy-diff.sh
diff options
context:
space:
mode:
authorSam Clegg <sbc@chromium.org>2020-04-16 22:06:03 -0400
committerGitHub <noreply@github.com>2020-04-16 19:06:03 -0700
commite30f52e59d2fdb578030685c19a60df5774e366e (patch)
tree0f7742dd4bbbe4f575283d982b61ebf5ab141c75 /scripts/clang-tidy-diff.sh
parent727c91af3bc1a317107fbffb0e7bab778dc3f5b6 (diff)
downloadbinaryen-e30f52e59d2fdb578030685c19a60df5774e366e.tar.gz
binaryen-e30f52e59d2fdb578030685c19a60df5774e366e.tar.bz2
binaryen-e30f52e59d2fdb578030685c19a60df5774e366e.zip
Report errors in scripts/clang-tidy-diff.sh if clang-tidy is not found (#2775)
Diffstat (limited to 'scripts/clang-tidy-diff.sh')
-rwxr-xr-xscripts/clang-tidy-diff.sh15
1 files changed, 12 insertions, 3 deletions
diff --git a/scripts/clang-tidy-diff.sh b/scripts/clang-tidy-diff.sh
index 5f3495504..c3f3cc4a2 100755
--- a/scripts/clang-tidy-diff.sh
+++ b/scripts/clang-tidy-diff.sh
@@ -15,11 +15,20 @@ else
BRANCH=origin/master
fi
-CLANG_DIR=$(dirname $(dirname $(which clang-tidy)))
+CLANG_TIDY=$(which clang-tidy)
+if [ ! -e "$CLANG_TIDY" ]; then
+ echo "Failed to find clang-tidy ($CLANG_TIDY)"
+ exit 1
+fi
+
+CLANG_DIR=$(dirname $(dirname $CLANG_TIDY))
CLANG_TIDY_DIFF=$CLANG_DIR/share/clang/clang-tidy-diff.py
+if [ ! -e "$CLANG_TIDY_DIFF" ]; then
+ echo "Failed to find clang-tidy-diff.py ($CLANG_TIDY_DIFF)"
+ exit 1
+fi
TIDY_MSG=$(git diff -U0 $BRANCH... | $CLANG_TIDY_DIFF -quiet -p1 2> /dev/null)
-if [ -n "$TIDY_MSG" -a "$TIDY_MSG" != "No relevant changes found." ]
-then
+if [ -n "$TIDY_MSG" -a "$TIDY_MSG" != "No relevant changes found." ]; then
echo "Please fix clang-tidy errors before committing"
echo
# Run clang-tidy once again to show the error