diff options
| author | Alon Zakai <azakai@google.com> | 2024-05-08 13:35:45 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-08 13:35:45 -0700 |
| commit | a288a73e1126111833c9f0cad533f84f2e4f6423 (patch) | |
| tree | e8dcb3e8cfd5f863f2d7f3130c489eeced567ab9 /scripts/fuzz_opt.py | |
| parent | ed2cec473a03c83d169775fb47c5bef89e312719 (diff) | |
| download | binaryen-a288a73e1126111833c9f0cad533f84f2e4f6423.tar.gz binaryen-a288a73e1126111833c9f0cad533f84f2e4f6423.tar.bz2 binaryen-a288a73e1126111833c9f0cad533f84f2e4f6423.zip | |
Fuzzer: Stop emitting nullable stringviews (#6574)
As of
https://chromium-review.googlesource.com/c/v8/v8/+/5471674
V8 requires stringviews to be non-nullable. It might be possible to make that
change in our IR, or to remove views entirely, but for now this PR makes the
fuzzer stop emitting nullable stringviews as a workaround to allow us to fuzz
current V8.
There are still rare corner cases where this pattern is emitted, that we have
not tracked down, and so this also makes the fuzzer ignore the error for now.
Diffstat (limited to 'scripts/fuzz_opt.py')
| -rwxr-xr-x | scripts/fuzz_opt.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/scripts/fuzz_opt.py b/scripts/fuzz_opt.py index 887b6abe9..6db2bd3bc 100755 --- a/scripts/fuzz_opt.py +++ b/scripts/fuzz_opt.py @@ -668,6 +668,9 @@ def run_vm(cmd): HOST_LIMIT_PREFIX, # see comment above on this constant V8_UNINITIALIZED_NONDEF_LOCAL, + # V8 does not accept nullable stringviews + # (https://github.com/WebAssembly/binaryen/pull/6574) + 'expected (ref stringview_wtf16), got nullref', ] for issue in known_issues: if issue in output: |