diff options
| author | Thomas Lively <tlively@google.com> | 2024-12-20 12:10:18 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-20 12:10:18 -0800 |
| commit | 43da2c7ff5069a4cb5733b4efcdbd573977e3c46 (patch) | |
| tree | 0a7a8505fb2cc9f060bb77a37845a99a5ad47b74 /scripts/test/shared.py | |
| parent | ac7cae5ba45f2995b045927ed1d7c03f1fded227 (diff) | |
| download | binaryen-43da2c7ff5069a4cb5733b4efcdbd573977e3c46.tar.gz binaryen-43da2c7ff5069a4cb5733b4efcdbd573977e3c46.tar.bz2 binaryen-43da2c7ff5069a4cb5733b4efcdbd573977e3c46.zip | |
Update flake8 and fix errors (#7172)
The flake8 we were running on CI was too old and began giving spurious
errors about the uninterpreted contents of f-strings. Update to the
latest flake8 and fix all the new errors, including the previously
incorrect comment syntax in the .flake8 file.
Also remove scripts/storage.py, since it didn't seem to be used for
anything we currently need.
Diffstat (limited to 'scripts/test/shared.py')
| -rw-r--r-- | scripts/test/shared.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/test/shared.py b/scripts/test/shared.py index e0a51a73a..ac9a408b6 100644 --- a/scripts/test/shared.py +++ b/scripts/test/shared.py @@ -315,7 +315,7 @@ class Py2CalledProcessError(subprocess.CalledProcessError): def run_process(cmd, check=True, input=None, capture_output=False, decode_output=True, *args, **kw): - if input and type(input) == str: + if input and type(input) is str: input = bytes(input, 'utf-8') if capture_output: kw['stdout'] = subprocess.PIPE @@ -358,7 +358,7 @@ def fail_if_not_contained(actual, expected): def fail_if_not_identical_to_file(actual, expected_file): - binary = expected_file.endswith(".wasm") or type(actual) == bytes + binary = expected_file.endswith(".wasm") or type(actual) is bytes with open(expected_file, 'rb' if binary else 'r') as f: fail_if_not_identical(actual, f.read(), fromfile=expected_file) |