diff options
| author | Sam Clegg <sbc@chromium.org> | 2020-07-24 11:53:28 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-07-24 11:53:28 -0700 |
| commit | c0cbee736291e75bfe78c726de3fa065ee167a50 (patch) | |
| tree | f429611420746ccb4703cdfa692268e6cf635d6a /scripts/test | |
| parent | 1f231c39e52eab712eda9bcbf540752b813b567d (diff) | |
| download | binaryen-c0cbee736291e75bfe78c726de3fa065ee167a50.tar.gz binaryen-c0cbee736291e75bfe78c726de3fa065ee167a50.tar.bz2 binaryen-c0cbee736291e75bfe78c726de3fa065ee167a50.zip | |
Update flags used in generate_lld_tests (#2981)
The `--no-gc-sections` was added as part of #2857 but is not
needed and in fact changes the output of some tests.
`--experimental-pic` is needed these days when building shared
libraries with emscripten's abi.
After these two changes I verfied that the following command
generated no local changes (i.e. is a no-op):
./scripts/test/generate_lld_tests.py --binaryen-bin=$PWD/../binaryen-out/bin/ $PWD/../llvm-build/bin/ $PWD/../emscripten
Diffstat (limited to 'scripts/test')
| -rwxr-xr-x | scripts/test/generate_lld_tests.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/test/generate_lld_tests.py b/scripts/test/generate_lld_tests.py index 8338ffbd9..c40d6ff63 100755 --- a/scripts/test/generate_lld_tests.py +++ b/scripts/test/generate_lld_tests.py @@ -69,7 +69,6 @@ def generate_wat_files(llvm_bin, emscripten_root): '--export', '__wasm_call_ctors', '--export', '__data_end', '--global-base=568', - '--no-gc-sections', ] # We had a regression where this test only worked if debug names # were included. @@ -79,6 +78,7 @@ def generate_wat_files(llvm_bin, emscripten_root): compile_cmd.append('-fPIC') compile_cmd.append('-fvisibility=default') link_cmd.append('-shared') + link_cmd.append('--experimental-pic') else: link_cmd.append('--entry=main') |