diff options
| author | Alon Zakai <azakai@google.com> | 2020-08-10 12:45:23 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-10 12:45:23 -0700 |
| commit | 454a1cb0b90397593472b9dd31c5418e23c40be3 (patch) | |
| tree | d9ae05c497b396594974df6b1a1b9c594d5fdcc8 /scripts | |
| parent | e80fc8098e31833894ddd243d6c29d4a6c9d6565 (diff) | |
| download | binaryen-454a1cb0b90397593472b9dd31c5418e23c40be3.tar.gz binaryen-454a1cb0b90397593472b9dd31c5418e23c40be3.tar.bz2 binaryen-454a1cb0b90397593472b9dd31c5418e23c40be3.zip | |
Remove unneeded old binary validation in test suite (#3034)
This was useful back when we didn't have many VMs to test in, and
we weren't confident in our binaries being valid wasm. Today we have
lots of testing on VMs, and in particular, this test tends to fail when we
do things like reorder SIMD opcode constants. (This doesn't fail on CI
as we don't have v8 installed there, so this path is never reached, but
it does happen locally.)
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/test/shared.py | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/scripts/test/shared.py b/scripts/test/shared.py index fe37d9105..d677c33a6 100644 --- a/scripts/test/shared.py +++ b/scripts/test/shared.py @@ -442,16 +442,6 @@ options.spec_tests = [t for t in options.spec_tests if os.path.basename(t) not # check utilities - -def validate_binary(wasm): - if V8: - cmd = [V8] + V8_OPTS + [in_binaryen('scripts', 'validation_shell.js'), '--', wasm] - print(' ', ' '.join(cmd)) - subprocess.check_call(cmd, stdout=subprocess.PIPE) - else: - print('(skipping v8 binary validation)') - - def binary_format_check(wast, verify_final_result=True, wasm_as_args=['-g'], binary_suffix='.fromBinary', original_wast=None): # checks we can convert the wast to binary and back @@ -464,13 +454,6 @@ def binary_format_check(wast, verify_final_result=True, wasm_as_args=['-g'], subprocess.check_call(cmd, stdout=subprocess.PIPE) assert os.path.exists('a.wasm') - # make sure it is a valid wasm, using a real wasm VM - if os.path.basename(original_wast or wast) not in [ - 'atomics.wast', # https://bugs.chromium.org/p/v8/issues/detail?id=9425 - 'simd.wast', # https://bugs.chromium.org/p/v8/issues/detail?id=8460 - ]: - validate_binary('a.wasm') - cmd = WASM_DIS + ['a.wasm', '-o', 'ab.wast'] print(' ', ' '.join(cmd)) if os.path.exists('ab.wast'): |