diff options
| author | Alon Zakai <azakai@google.com> | 2024-08-16 10:53:10 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-16 10:53:10 -0700 |
| commit | 7209629bec3961fcc12b150ba6df546d3997b6c2 (patch) | |
| tree | 8cd5e8fb3c448341fb002fa53444d6b2fe01a0bd /scripts | |
| parent | c2b43802c68a15d42c64f9404a398a842312f95a (diff) | |
| download | binaryen-7209629bec3961fcc12b150ba6df546d3997b6c2.tar.gz binaryen-7209629bec3961fcc12b150ba6df546d3997b6c2.tar.bz2 binaryen-7209629bec3961fcc12b150ba6df546d3997b6c2.zip | |
Testing: Add an env var to pick the V8 binary (#6836)
Also we had a mix of os.environ.get and os.getenv. Prefer the former, as the default
value does actual work, so it's a little more efficient to not run it unnecessarily. That is,
os.getenv('X', work()) is less efficient than os.environ.get('X') or work().
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/test/shared.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/test/shared.py b/scripts/test/shared.py index d593aa45b..91612a8d9 100644 --- a/scripts/test/shared.py +++ b/scripts/test/shared.py @@ -195,10 +195,10 @@ NATIVECC = (os.environ.get('CC') or which('mingw32-gcc') or which('gcc') or which('clang')) NATIVEXX = (os.environ.get('CXX') or which('mingw32-g++') or which('g++') or which('clang++')) -NODEJS = os.getenv('NODE', which('node') or which('nodejs')) +NODEJS = os.environ.get('NODE') or which('node') or which('nodejs') MOZJS = which('mozjs') or which('spidermonkey') -V8 = which('v8') or which('d8') +V8 = os.environ.get('V8') or which('v8') or which('d8') BINARYEN_INSTALL_DIR = os.path.dirname(options.binaryen_bin) WASM_OPT = [os.path.join(options.binaryen_bin, 'wasm-opt')] |