diff options
| author | Thomas Lively <tlively@google.com> | 2024-08-26 10:15:00 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-26 10:15:00 -0700 |
| commit | dacc6e57048dc9af133c98ea3c843f8b912c9980 (patch) | |
| tree | 8148a61bb1109a1661c7f1800047bcdbc2dc5619 /scripts | |
| parent | 95a280f70ef529c3c506d628648a96f2d267f4c1 (diff) | |
| download | binaryen-dacc6e57048dc9af133c98ea3c843f8b912c9980.tar.gz binaryen-dacc6e57048dc9af133c98ea3c843f8b912c9980.tar.bz2 binaryen-dacc6e57048dc9af133c98ea3c843f8b912c9980.zip | |
Support more reference constants in wast scripts (#6865)
Spec tests use constants like `ref.array` and `ref.eq` to assert that
exported function return references of the correct types. Support more
such constants in the wast parser.
Also fix a bug where the interpretation of `array.new_data` for arrays
of packed fields was not properly truncating the packed data. Move the
function for reading fields from memory from literal.cpp to
wasm-interpreter.h, where the function for truncating packed data lives.
Other bugs prevent us from enabling any more spec tests as a result of
this change, but we can get farther through several of them before
failing. Update the comments about the failures accordingly.
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/test/shared.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/scripts/test/shared.py b/scripts/test/shared.py index 019d2b251..4ca065d03 100644 --- a/scripts/test/shared.py +++ b/scripts/test/shared.py @@ -452,16 +452,16 @@ SPEC_TESTSUITE_TESTS_TO_SKIP = [ 'table.wast', # Requires support for table default elements 'type-equivalence.wast', # Recursive types allowed by GC 'unreached-invalid.wast', # Requires more precise unreachable validation - 'array.wast', # Requires ref.array wast constants + 'array.wast', # Requires support for table default elements 'array_init_elem.wast', # Requires support for elem.drop 'br_if.wast', # Requires more precise branch validation 'br_on_cast.wast', # Requires sending values on br_on_cast 'br_on_cast_fail.wast', # Requires sending values on br_on_cast_fail 'extern.wast', # Requires ref.host wast constants - 'i31.wast', # Requires ref.i31 wast constants + 'i31.wast', # Requires support for table default elements 'ref_cast.wast', # Requires host references to not be externalized i31refs 'ref_test.wast', # Requires host references to not be externalized i31refs - 'struct.wast', # Requires ref.struct wast constants + 'struct.wast', # Duplicate field names not properly rejected 'type-rec.wast', # Requires wast `register` support 'type-subtyping.wast', # ShellExternalInterface::callTable does not handle subtyping 'call_indirect.wast', # Bug with 64-bit inline element segment parsing |