diff options
author | JF Bastien <jfb@chromium.org> | 2016-02-02 06:14:34 -0800 |
---|---|---|
committer | JF Bastien <jfb@chromium.org> | 2016-02-02 06:14:34 -0800 |
commit | b20025479124b041c94f9bf6f8053eaa95e46c0c (patch) | |
tree | 677b97ee53c3840b7a1d2d4790a208ae505cc577 /src/asm2wasm.h | |
parent | 4044cbd8fe593a118456079eaddfb393c84b9e76 (diff) | |
download | binaryen-b20025479124b041c94f9bf6f8053eaa95e46c0c.tar.gz binaryen-b20025479124b041c94f9bf6f8053eaa95e46c0c.tar.bz2 binaryen-b20025479124b041c94f9bf6f8053eaa95e46c0c.zip |
Make Literal's ctors explicit
This tends to avoid silly mistakes, which I'm worried about after adding an explicit ctor with the enum WasmType parameter. See 'C++ Coding Standards: 101 Rules, Guidelines, and Best Practices' rule #40 'avoid providing implicit conversion'.
Diffstat (limited to 'src/asm2wasm.h')
-rw-r--r-- | src/asm2wasm.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/asm2wasm.h b/src/asm2wasm.h index d29c36a6e..473384f2e 100644 --- a/src/asm2wasm.h +++ b/src/asm2wasm.h @@ -1104,13 +1104,13 @@ Function* Asm2WasmBuilder::processFunction(Ref ast) { auto isNegative = allocator.alloc<Binary>(); isNegative->op = LtS; isNegative->left = get(); - isNegative->right = allocator.alloc<Const>()->set(0); + isNegative->right = allocator.alloc<Const>()->set(Literal(0)); isNegative->finalize(); auto block = allocator.alloc<Block>(); block->list.push_back(set); auto flip = allocator.alloc<Binary>(); flip->op = Sub; - flip->left = allocator.alloc<Const>()->set(0); + flip->left = allocator.alloc<Const>()->set(Literal(0)); flip->right = get(); flip->type = i32; auto select = allocator.alloc<Select>(); |