Remove FunctionType (#2510)

Function signatures were previously redundantly stored on Function
objects as well as on FunctionType objects. These two signature
representations had to always be kept in sync, which was error-prone
and needlessly complex. This PR takes advantage of the new ability of
Type to represent multiple value types by consolidating function
signatures as a pair of Types (params and results) stored on the
Function object.

Since there are no longer module-global named function types,
significant changes had to be made to the printing and emitting of
function types, as well as their parsing and manipulation in various
passes.

The C and JS APIs and their tests also had to be updated to remove
named function types.

1 files changed, 1 insertions, 27 deletions

diff --git a/src/asm_v_wasm.h b/src/asm_v_wasm.h
index 95b4cbbca..d7e2e5b24 100644
--- a/src/asm_v_wasm.h
+++ b/src/asm_v_wasm.h
@@ -28,19 +28,8 @@ Type asmToWasmType(AsmType asmType);
 AsmType wasmToAsmType(Type type);
 
 char getSig(Type type);
-
-template<typename ListType>
-std::string getSig(const ListType& params, Type result) {
-  std::string ret;
-  ret += getSig(result);
-  for (auto param : params) {
-    ret += getSig(param);
-  }
-  return ret;
-}
-
-std::string getSig(const FunctionType* type);
 std::string getSig(Function* func);
+std::string getSig(Type results, Type params);
 
 template<typename T,
          typename std::enable_if<std::is_base_of<Expression, T>::value>::type* =
@@ -74,21 +63,6 @@ std::string getSigFromStructs(Type result, const ListType& operands) {
   return ret;
 }
 
-Type sigToType(char sig);
-
-FunctionType sigToFunctionType(const std::string& sig);
-
-FunctionType*
-ensureFunctionType(const std::string& sig, Module* wasm, Name name = Name());
-
-template<typename ListType>
-FunctionType* ensureFunctionType(const ListType& params,
-                                 Type result,
-                                 Module* wasm,
-                                 Name name = Name()) {
-  return ensureFunctionType(getSig(params, result), wasm, name);
-}
-
 // converts an f32 to an f64 if necessary
 Expression* ensureDouble(Expression* expr, MixedArena& allocator);