Refactor type and function parsing (#2143)

- Refactored & fixed typeuse parsing rules so now the rules more closely
  follow the spec. There have been multiple parsing rules that were
  different in subtle ways, which are supposed to be the same according
  to the spec.
  - Duplicate types, i.e., types with the same signature, in the type
    section are allowed as long as they don't have the same given name.
    If a name is given, we use it; if type name is not given, we
    generate one in the form of `$FUNCSIG$` + signature string. If the
    same generated name already exists in the type section, we append
    `_` at the end. This causes most of the changes in the autogenerated
    type names in test outputs.
  - A typeuse has to be in the order of (type) -> (param) -> (result),
    if more than one of them exist. In case of function definitions,
    (local) has to be after all of these. Fixed some test cases that
    violate this rule.
  - When only (param)/(result) are given, its type will be the type with
    the smallest existing type index whose parameter and result are the
    same. If there's no such type, a new type will be created and
    inserted.
  - Added a test case `duplicate_types.wast` to test type namings for
    duplicate types.

- Refactored `parseFunction` function.

- Add more overrides to helper functions: `getSig` and
  `ensureFunctionType`.

1 files changed, 21 insertions, 3 deletions

diff --git a/src/asm_v_wasm.h b/src/asm_v_wasm.h
index 66601cf10..95b4cbbca 100644
--- a/src/asm_v_wasm.h
+++ b/src/asm_v_wasm.h
@@ -29,8 +29,17 @@ AsmType wasmToAsmType(Type type);
 
 char getSig(Type type);
 
-std::string getSig(const FunctionType* type);
+template<typename ListType>
+std::string getSig(const ListType& params, Type result) {
+  std::string ret;
+  ret += getSig(result);
+  for (auto param : params) {
+    ret += getSig(param);
+  }
+  return ret;
+}
 
+std::string getSig(const FunctionType* type);
 std::string getSig(Function* func);
 
 template<typename T,
@@ -67,9 +76,18 @@ std::string getSigFromStructs(Type result, const ListType& operands) {
 
 Type sigToType(char sig);
 
-FunctionType sigToFunctionType(std::string sig);
+FunctionType sigToFunctionType(const std::string& sig);
+
+FunctionType*
+ensureFunctionType(const std::string& sig, Module* wasm, Name name = Name());
 
-FunctionType* ensureFunctionType(std::string sig, Module* wasm);
+template<typename ListType>
+FunctionType* ensureFunctionType(const ListType& params,
+                                 Type result,
+                                 Module* wasm,
+                                 Name name = Name()) {
+  return ensureFunctionType(getSig(params, result), wasm, name);
+}
 
 // converts an f32 to an f64 if necessary
 Expression* ensureDouble(Expression* expr, MixedArena& allocator);