diff options
| author | Alon Zakai <azakai@google.com> | 2021-09-13 11:33:00 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-13 11:33:00 -0700 |
| commit | ec2c5df877c479855bd13d280b98220e50bb99f9 (patch) | |
| tree | 27ea5e95fa15846cb7773552a78b95c3f476cf04 /src/ir/bits.h | |
| parent | 5b90e0332253ee879d16fbc29d391ad75734ecf5 (diff) | |
| download | binaryen-ec2c5df877c479855bd13d280b98220e50bb99f9.tar.gz binaryen-ec2c5df877c479855bd13d280b98220e50bb99f9.tar.bz2 binaryen-ec2c5df877c479855bd13d280b98220e50bb99f9.zip | |
OptimizeInstructions: Optimize boolean selects (#4147)
If all a select's inputs are boolean, we can sometimes turn the select
into an AND or an OR operation,
x ? y : 0 => x & y
x ? 1 : y => x | y
I believe LLVM aggressively canonicalizes to this form. It makes sense
to do here too as it is smaller (save the constant 0 or 1). It also allows
further optimizations (which is why LLVM does it) but I don't think we
have those yet.
Diffstat (limited to 'src/ir/bits.h')
| -rw-r--r-- | src/ir/bits.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/ir/bits.h b/src/ir/bits.h index 950864a23..dc02bd8f8 100644 --- a/src/ir/bits.h +++ b/src/ir/bits.h @@ -413,6 +413,8 @@ Index getMaxBits(Expression* curr, // a tee passes through the value return getMaxBits(set->value, localInfoProvider); } else if (auto* get = curr->dynCast<LocalGet>()) { + // TODO: Should this be optional? + assert(localInfoProvider); return localInfoProvider->getMaxBitsForLocal(get); } else if (auto* load = curr->dynCast<Load>()) { // if signed, then the sign-extension might fill all the bits |