diff options
| author | Heejin Ahn <aheejin@gmail.com> | 2022-07-26 15:54:48 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-26 15:54:48 -0700 |
| commit | 24552779ebfbfc8f296d169c1462308aea27591c (patch) | |
| tree | 5448f785c53a8818b6099b0e67d2ca09dd1ac8fa /src/ir/drop.cpp | |
| parent | 61483f5e77e6a6b1370e60044ebb20b22b6abb71 (diff) | |
| download | binaryen-24552779ebfbfc8f296d169c1462308aea27591c.tar.gz binaryen-24552779ebfbfc8f296d169c1462308aea27591c.tar.bz2 binaryen-24552779ebfbfc8f296d169c1462308aea27591c.zip | |
Fix unreachable handling in getDroppedChildrenAndAppend (#4834)
The previous code assumes if `last`'s type is unreachable it traps. But
it's not always the case because it can be other instructions like `br`
whose type is unreachable but doesn't necessarily trap.
Context:
https://github.com/WebAssembly/binaryen/pull/4827#discussion_r929395477
Diffstat (limited to 'src/ir/drop.cpp')
| -rw-r--r-- | src/ir/drop.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/ir/drop.cpp b/src/ir/drop.cpp index 14ab43794..d033c0876 100644 --- a/src/ir/drop.cpp +++ b/src/ir/drop.cpp @@ -44,7 +44,7 @@ Expression* getDroppedChildrenAndAppend(Expression* curr, // effects would never help us (and would be slower to run). ShallowEffectAnalyzer effects(options, wasm, curr); // Ignore a trap, as the unreachable replacement would trap too. - if (last->type == Type::unreachable) { + if (last->is<Unreachable>()) { effects.trap = false; } |