Reflect instruction renaming in code (#2128)

- Reflected new renamed instruction names in code and tests:
  - `get_local` -> `local.get`
  - `set_local` -> `local.set`
  - `tee_local` -> `local.tee`
  - `get_global` -> `global.get`
  - `set_global` -> `global.set`
  - `current_memory` -> `memory.size`
  - `grow_memory` -> `memory.grow`

- Removed APIs related to old instruction names in Binaryen.js and added
  APIs with new names if they are missing.

- Renamed `typedef SortedVector LocalSet` to `SetsOfLocals` to prevent
  name clashes.

- Resolved several TODO renaming items in wasm-binary.h:
  - `TableSwitch` -> `BrTable`
  - `I32ConvertI64` -> `I32WrapI64`
  - `I64STruncI32` -> `I64SExtendI32`
  - `I64UTruncI32` -> `I64UExtendI32`
  - `F32ConvertF64` -> `F32DemoteI64`
  - `F64ConvertF32` -> `F64PromoteF32`

- Renamed `BinaryenGetFeatures` and `BinaryenSetFeatures` to
  `BinaryenModuleGetFeatures` and `BinaryenModuleSetFeatures` for
  consistency.

1 files changed, 7 insertions, 7 deletions

diff --git a/src/ir/effects.h b/src/ir/effects.h
index bbcce07de..7c64beafd 100644
--- a/src/ir/effects.h
+++ b/src/ir/effects.h
@@ -64,7 +64,7 @@ struct EffectAnalyzer
   // side effects
   bool implicitTrap = false;
   // An atomic load/store/RMW/Cmpxchg or an operator that has a defined ordering
-  // wrt atomics (e.g. grow_memory)
+  // wrt atomics (e.g. memory.grow)
   bool isAtomic = false;
 
   // Helper functions to check for various effect types
@@ -231,10 +231,10 @@ struct EffectAnalyzer
     }
   }
   void visitCallIndirect(CallIndirect* curr) { calls = true; }
-  void visitGetLocal(GetLocal* curr) { localsRead.insert(curr->index); }
-  void visitSetLocal(SetLocal* curr) { localsWritten.insert(curr->index); }
-  void visitGetGlobal(GetGlobal* curr) { globalsRead.insert(curr->name); }
-  void visitSetGlobal(SetGlobal* curr) { globalsWritten.insert(curr->name); }
+  void visitLocalGet(LocalGet* curr) { localsRead.insert(curr->index); }
+  void visitLocalSet(LocalSet* curr) { localsWritten.insert(curr->index); }
+  void visitGlobalGet(GlobalGet* curr) { globalsRead.insert(curr->name); }
+  void visitGlobalSet(GlobalSet* curr) { globalsWritten.insert(curr->name); }
   void visitLoad(Load* curr) {
     readsMemory = true;
     isAtomic |= curr->isAtomic;
@@ -360,10 +360,10 @@ struct EffectAnalyzer
   void visitReturn(Return* curr) { branches = true; }
   void visitHost(Host* curr) {
     calls = true;
-    // grow_memory modifies the set of valid addresses, and thus can be modeled
+    // memory.grow modifies the set of valid addresses, and thus can be modeled
     // as modifying memory
     writesMemory = true;
-    // Atomics are also sequentially consistent with grow_memory.
+    // Atomics are also sequentially consistent with memory.grow.
     isAtomic = true;
   }
   void visitNop(Nop* curr) {}