[Strings] Remove operations not included in imported strings (#6589)

The stringref proposal has been superseded by the imported JS strings proposal,
but the former has many more operations than the latter. To reduce complexity,
remove all operations that are part of stringref but not part of imported
strings.

1 files changed, 4 insertions, 32 deletions

diff --git a/src/ir/effects.h b/src/ir/effects.h
index 87b77601f..28de83850 100644
--- a/src/ir/effects.h
+++ b/src/ir/effects.h
@@ -941,23 +941,10 @@ private:
       // cycle may be needed in some cases.
     }
     void visitStringNew(StringNew* curr) {
-      // traps when out of bounds in linear memory or ref is null
+      // traps when ref is null
       parent.implicitTrap = true;
-      switch (curr->op) {
-        case StringNewUTF8:
-        case StringNewWTF8:
-        case StringNewLossyUTF8:
-        case StringNewWTF16:
-          parent.readsMemory = true;
-          break;
-        case StringNewUTF8Array:
-        case StringNewWTF8Array:
-        case StringNewLossyUTF8Array:
-        case StringNewWTF16Array:
-          parent.readsArray = true;
-          break;
-        default: {
-        }
+      if (curr->op != StringNewFromCodePoint) {
+        parent.readsArray = true;
       }
     }
     void visitStringConst(StringConst* curr) {}
@@ -968,22 +955,7 @@ private:
     void visitStringEncode(StringEncode* curr) {
       // traps when ref is null or we write out of bounds.
       parent.implicitTrap = true;
-      switch (curr->op) {
-        case StringEncodeUTF8:
-        case StringEncodeLossyUTF8:
-        case StringEncodeWTF8:
-        case StringEncodeWTF16:
-          parent.writesMemory = true;
-          break;
-        case StringEncodeUTF8Array:
-        case StringEncodeLossyUTF8Array:
-        case StringEncodeWTF8Array:
-        case StringEncodeWTF16Array:
-          parent.writesArray = true;
-          break;
-        default: {
-        }
-      }
+      parent.writesArray = true;
     }
     void visitStringConcat(StringConcat* curr) {
       // traps when an input is null.