diff options
author | Thomas Lively <tlively@google.com> | 2022-11-07 12:45:01 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-11-07 12:45:01 -0800 |
commit | b48e4de5ea13434ded315b2bc99a713db0361f63 (patch) | |
tree | a1c24b6f79c624f9affb538e1daf18e67d386743 /src/ir/effects.h | |
parent | 52079ae8ea3abec509c3184720d1824b9093cb2f (diff) | |
download | binaryen-b48e4de5ea13434ded315b2bc99a713db0361f63.tar.gz binaryen-b48e4de5ea13434ded315b2bc99a713db0361f63.tar.bz2 binaryen-b48e4de5ea13434ded315b2bc99a713db0361f63.zip |
Implement `array.new_data` and `array.new_elem` (#5214)
In order to test them, fix the binary and text parsers to accept passive data
segments even if a module has no memory. In addition to parsing and emitting the
new instructions, also implement their validation and interpretation. Test the
interpretation directly with wasm-shell tests adapted from the upstream spec
tests. Running the upstream spec tests directly would require fixing too many
bugs in the legacy text parser, so it will have to wait for the new text parser
to be ready.
Diffstat (limited to 'src/ir/effects.h')
-rw-r--r-- | src/ir/effects.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/ir/effects.h b/src/ir/effects.h index 2dfe616f9..70e9192c0 100644 --- a/src/ir/effects.h +++ b/src/ir/effects.h @@ -755,6 +755,11 @@ private: } } void visitArrayNew(ArrayNew* curr) {} + void visitArrayNewSeg(ArrayNewSeg* curr) { + // Traps on out of bounds access to segments or access to dropped + // segments. + parent.implicitTrap = true; + } void visitArrayInit(ArrayInit* curr) {} void visitArrayGet(ArrayGet* curr) { if (curr->ref->type.isNull()) { |