diff options
| author | Thomas Lively <tlively@google.com> | 2023-01-09 16:23:57 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-09 14:23:57 -0800 |
| commit | 67abc2a1b9adcdf080387a29e0c92b6f5a31057a (patch) | |
| tree | d8e8304e9ecdd700b56b949bb5132b26e09362f4 /src/ir/possible-contents.cpp | |
| parent | e3d9b82d9f8910063373e2952582de545659d448 (diff) | |
| download | binaryen-67abc2a1b9adcdf080387a29e0c92b6f5a31057a.tar.gz binaryen-67abc2a1b9adcdf080387a29e0c92b6f5a31057a.tar.bz2 binaryen-67abc2a1b9adcdf080387a29e0c92b6f5a31057a.zip | |
Replace `RefIs` with `RefIsNull` (#5401)
* Replace `RefIs` with `RefIsNull`
The other `ref.is*` instructions are deprecated and expressible in terms of
`ref.test`. Update binary and text parsing to parse those instructions as
`RefTest` expressions. Also update the printing and emitting of `RefTest`
expressions to emit the legacy instructions for now to minimize test changes and
make this a mostly non-functional change. Since `ref.is_null` is the only
`RefIs` instruction left, remove the `RefIsOp` field and rename the expression
class to `RefIsNull`.
The few test changes are due to the fact that `ref.is*` instructions are now
subject to `ref.test` validation, and in particular it is no longer valid to
perform a `ref.is_func` on a value outside of the `func` type hierarchy.
Diffstat (limited to 'src/ir/possible-contents.cpp')
| -rw-r--r-- | src/ir/possible-contents.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/ir/possible-contents.cpp b/src/ir/possible-contents.cpp index 52b05057f..cf30cd917 100644 --- a/src/ir/possible-contents.cpp +++ b/src/ir/possible-contents.cpp @@ -587,7 +587,7 @@ struct InfoCollector curr, PossibleContents::literal(Literal::makeNull(curr->type.getHeapType()))); } - void visitRefIs(RefIs* curr) { + void visitRefIsNull(RefIsNull* curr) { // TODO: Optimize when possible. For example, if we can infer an exact type // here which allows us to know the result then we should do so. This // is unlike the case in visitUnary, above: the information that lets |