diff options
author | Alon Zakai <azakai@google.com> | 2024-05-15 09:42:28 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-15 09:42:28 -0700 |
commit | 8a5dc1880d962a7c31a7a219720be343a0866e5c (patch) | |
tree | b76322419dac9600599be135a6558d661aafb709 /src/ir/possible-contents.cpp | |
parent | 940f4570cb13db7f7b381cbe35ba546708ed7556 (diff) | |
download | binaryen-8a5dc1880d962a7c31a7a219720be343a0866e5c.tar.gz binaryen-8a5dc1880d962a7c31a7a219720be343a0866e5c.tar.bz2 binaryen-8a5dc1880d962a7c31a7a219720be343a0866e5c.zip |
LocalCSE: Fix regression from #6587 by accumulating generativity (#6591)
#6587 was incorrect: It checked generativity early in an incremental manner, but
it did not accumulate that information as we do with hashes. As a result we
could end up optimizing something with a generative child, and sadly we lacked
testing for that case.
This adds incremental generativity computation alongside hashes. It also splits
out this check from isRelevant.
Also add a test for nested effects (as opposed to generativity), but that already
worked before this PR (as we compute effects and invalidation as we go, already).
Diffstat (limited to 'src/ir/possible-contents.cpp')
0 files changed, 0 insertions, 0 deletions