diff options
| author | Thomas Lively <7121787+tlively@users.noreply.github.com> | 2021-03-29 15:34:48 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-29 15:34:48 -0700 |
| commit | 9b38e4394034d6f25f54fc471bb9ac8812815331 (patch) | |
| tree | 9f438f8287f838e303f9c56970e7bb9ad16ebc79 /src/ir/utils.h | |
| parent | 09cba0fa50b0492ecf7b7886180dbd6c5aa5d04d (diff) | |
| download | binaryen-9b38e4394034d6f25f54fc471bb9ac8812815331.tar.gz binaryen-9b38e4394034d6f25f54fc471bb9ac8812815331.tar.bz2 binaryen-9b38e4394034d6f25f54fc471bb9ac8812815331.zip | |
LUBs (#3731)
This is a partial revert of #3669, which removed the old implementation of
Type::getLeastUpperBound that did not correctly handle recursive types. The new
implementation in this PR uses a TypeBuilder to construct LUBs and for recursive
types, it returns a temporary HeapType that has not yet been fully constructed
to break what would otherwise be infinite recursions.
Diffstat (limited to 'src/ir/utils.h')
| -rw-r--r-- | src/ir/utils.h | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/ir/utils.h b/src/ir/utils.h index fa3e34423..805844a71 100644 --- a/src/ir/utils.h +++ b/src/ir/utils.h @@ -107,11 +107,8 @@ struct ReFinalize ReFinalize() { name = "refinalize"; } // block finalization is O(bad) if we do each block by itself, so do it in - // bulk, tracking break value types so we just do a linear pass - - // TODO: Switch to std::unordered_set once types are properly canonicalized so - // determinism isn't an issue. - std::unordered_map<Name, std::set<Type>> breakTypes; + // bulk, tracking break value types so we just do a linear pass. + std::unordered_map<Name, std::unordered_set<Type>> breakTypes; #define DELEGATE(CLASS_TO_VISIT) \ void visit##CLASS_TO_VISIT(CLASS_TO_VISIT* curr); |