diff options
| author | Thomas Lively <tlively@google.com> | 2024-12-20 17:45:47 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-21 01:45:47 +0000 |
| commit | 6ddacde514af7cc546caa07fede4baa3e429c33c (patch) | |
| tree | 3436a22906ae3b94d3308e738a31d3db559bf246 /src/parser/parsers.h | |
| parent | 4d8a933e1136159160f2b45ad3a9a1c82021a75b (diff) | |
| download | binaryen-6ddacde514af7cc546caa07fede4baa3e429c33c.tar.gz binaryen-6ddacde514af7cc546caa07fede4baa3e429c33c.tar.bz2 binaryen-6ddacde514af7cc546caa07fede4baa3e429c33c.zip | |
[NFC] Make MemoryOrder parameters non-optional (#7171)
Update Builder and IRBuilder makeStructGet and makeStructSet functions
to require the memory order to be explicitly supplied. This is slightly
more verbose, but will reduce the chances that we forget to properly
consider synchronization when implementing new features in the future.
Diffstat (limited to 'src/parser/parsers.h')
| -rw-r--r-- | src/parser/parsers.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/parser/parsers.h b/src/parser/parsers.h index 1f7236403..59f34038d 100644 --- a/src/parser/parsers.h +++ b/src/parser/parsers.h @@ -2240,7 +2240,8 @@ Result<> makeStructGet(Ctx& ctx, CHECK_ERR(type); auto field = fieldidx(ctx, *type); CHECK_ERR(field); - return ctx.makeStructGet(pos, annotations, *type, *field, signed_); + return ctx.makeStructGet( + pos, annotations, *type, *field, signed_, MemoryOrder::Unordered); } template<typename Ctx> @@ -2264,7 +2265,8 @@ makeStructSet(Ctx& ctx, Index pos, const std::vector<Annotation>& annotations) { CHECK_ERR(type); auto field = fieldidx(ctx, *type); CHECK_ERR(field); - return ctx.makeStructSet(pos, annotations, *type, *field); + return ctx.makeStructSet( + pos, annotations, *type, *field, MemoryOrder::Unordered); } template<typename Ctx> |