summaryrefslogtreecommitdiff
path: root/src/passes/Asyncify.cpp
diff options
context:
space:
mode:
authorAlon Zakai <azakai@google.com>2023-10-06 16:41:13 -0700
committerGitHub <noreply@github.com>2023-10-06 16:41:13 -0700
commitb3775b5e4e150439276ad3d34f1bb564b28e8ef5 (patch)
treeeb7b09492205249f08459ffee38e081b83cbf17d /src/passes/Asyncify.cpp
parent9c1107d17c0b7223bd377d9ab4f36fe54ef07c7d (diff)
downloadbinaryen-b3775b5e4e150439276ad3d34f1bb564b28e8ef5.tar.gz
binaryen-b3775b5e4e150439276ad3d34f1bb564b28e8ef5.tar.bz2
binaryen-b3775b5e4e150439276ad3d34f1bb564b28e8ef5.zip
Automatically discard global effects in the rare passes that add effects (#5999)
All logging/instrumentation passes need to do this, to avoid us using stale global effects that are too low (too high is not optimal either, but at least it cannot cause bugs).
Diffstat (limited to 'src/passes/Asyncify.cpp')
-rw-r--r--src/passes/Asyncify.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/passes/Asyncify.cpp b/src/passes/Asyncify.cpp
index d0674d97c..2412a754a 100644
--- a/src/passes/Asyncify.cpp
+++ b/src/passes/Asyncify.cpp
@@ -870,6 +870,8 @@ struct InstrumentedProxy : public Pass {
bool invalidatesDWARF() override { return pass->invalidatesDWARF(); }
+ bool addsEffects() override { return pass->addsEffects(); }
+
bool requiresNonNullableLocalFixups() override {
return pass->requiresNonNullableLocalFixups();
}
@@ -1610,6 +1612,9 @@ static std::string getFullImportName(Name module, Name base) {
}
struct Asyncify : public Pass {
+ // Adds calls.
+ bool addsEffects() override { return true; }
+
void run(Module* module) override {
auto& options = getPassOptions();
bool optimize = options.optimizeLevel > 0;