Use the new module version of EffectAnalyzer (#4116)

This finishes the refactoring started in #4115 by doing the
same change to pass a Module into EffectAnalyzer instead of
features. To do so this refactors the fallthrough API and a few
other small things. After those changes, this PR removes the
old feature constructor of EffectAnalyzer entirely.

This requires a small breaking change in the C API, changing
BinaryenExpressionGetSideEffects's feature param to a
module. That makes this change not NFC, but otherwise it is.

1 files changed, 8 insertions, 9 deletions

diff --git a/src/passes/AvoidReinterprets.cpp b/src/passes/AvoidReinterprets.cpp
index cc5871a2a..d1030f89e 100644
--- a/src/passes/AvoidReinterprets.cpp
+++ b/src/passes/AvoidReinterprets.cpp
@@ -40,7 +40,7 @@ static bool canReplaceWithReinterpret(Load* load) {
 static Load* getSingleLoad(LocalGraph* localGraph,
                            LocalGet* get,
                            const PassOptions& passOptions,
-                           FeatureSet features) {
+                           Module& module) {
   std::set<LocalGet*> seen;
   seen.insert(get);
   while (1) {
@@ -52,7 +52,7 @@ static Load* getSingleLoad(LocalGraph* localGraph,
     if (!set) {
       return nullptr;
     }
-    auto* value = Properties::getFallthrough(set->value, passOptions, features);
+    auto* value = Properties::getFallthrough(set->value, passOptions, module);
     if (auto* parentGet = value->dynCast<LocalGet>()) {
       if (seen.count(parentGet)) {
         // We are in a cycle of gets, in unreachable code.
@@ -102,12 +102,11 @@ struct AvoidReinterprets : public WalkerPass<PostWalker<AvoidReinterprets>> {
 
   void visitUnary(Unary* curr) {
     if (isReinterpret(curr)) {
-      FeatureSet features = getModule()->features;
-      if (auto* get =
-            Properties::getFallthrough(curr->value, getPassOptions(), features)
-              ->dynCast<LocalGet>()) {
+      if (auto* get = Properties::getFallthrough(
+                        curr->value, getPassOptions(), *getModule())
+                        ->dynCast<LocalGet>()) {
         if (auto* load =
-              getSingleLoad(localGraph, get, getPassOptions(), features)) {
+              getSingleLoad(localGraph, get, getPassOptions(), *getModule())) {
           auto& info = infos[load];
           info.reinterpreted = true;
         }
@@ -156,8 +155,8 @@ struct AvoidReinterprets : public WalkerPass<PostWalker<AvoidReinterprets>> {
               replaceCurrent(makeReinterpretedLoad(load, load->ptr));
             }
           } else if (auto* get = value->dynCast<LocalGet>()) {
-            if (auto* load = getSingleLoad(
-                  localGraph, get, passOptions, module->features)) {
+            if (auto* load =
+                  getSingleLoad(localGraph, get, passOptions, *module)) {
               auto iter = infos.find(load);
               if (iter != infos.end()) {
                 auto& info = iter->second;