Refactor Effects (#2873)

Avoid special work in analyze(). This lets breakTargets always
reflect the breaks that we've seen and that might be external, and
we check it in hasSideEffects etc.

Also do some internal refactoring and renamings for clarity.

1 files changed, 3 insertions, 1 deletions

diff --git a/src/passes/CodePushing.cpp b/src/passes/CodePushing.cpp
index 7fa50f39b..7af192838 100644
--- a/src/passes/CodePushing.cpp
+++ b/src/passes/CodePushing.cpp
@@ -163,7 +163,9 @@ private:
     cumulativeEffects.analyze(list[pushPoint]);
     // it is ok to ignore the branching here, that is the crucial point of this
     // opt
-    cumulativeEffects.branches = false;
+    // TODO: it would be ok to ignore thrown exceptions here, if we know they
+    //       could not be caught and must go outside of the function
+    cumulativeEffects.ignoreBranches();
     std::vector<LocalSet*> toPush;
     Index i = pushPoint - 1;
     while (1) {