diff options
author | 许鑫权 <XMadrid@users.noreply.github.com> | 2024-04-22 05:14:13 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-04-21 14:14:13 -0700 |
commit | 7b7832d65ce28702bbac1b44b6de854029c1e0b1 (patch) | |
tree | 998a0e803992673b370ba37785cd9952efd225b7 /src/passes/DebugLocationPropagation.cpp | |
parent | 219e668e87b012c0634043ed702534b8be31231f (diff) | |
download | binaryen-7b7832d65ce28702bbac1b44b6de854029c1e0b1.tar.gz binaryen-7b7832d65ce28702bbac1b44b6de854029c1e0b1.tar.bz2 binaryen-7b7832d65ce28702bbac1b44b6de854029c1e0b1.zip |
DebugLocationPropagation: pass debuglocation from parent node to chil… (#6500)
This PR creates a pass to propagate debug location from parent node to child nodes which has no debug location with pre-order traversal. This is useful for compilers that use Binaryen API to generate WebAssembly modules.
It behaves like `wasm-opt` read text format file: children are tagged with the debug info of the parent, if they have no annotation of their own.
For compilers that use Binaryen API to generate WebAssembly modules, it is a bit redundant to add debugInfo for each expression, Especially when the compiler wrap expressions.
With this pass, compilers just need to add debugInfo for the parent node, which is more convenient.
For example:
```
(drop
(call $voidFunc)
)
```
Without this pass, if the compiler only adds debugInfo for the wrapped expression `drop`, the `call` expression has no corresponding source code mapping in DevTools debugging, which is obviously not user-friendly.
Diffstat (limited to 'src/passes/DebugLocationPropagation.cpp')
-rw-r--r-- | src/passes/DebugLocationPropagation.cpp | 99 |
1 files changed, 99 insertions, 0 deletions
diff --git a/src/passes/DebugLocationPropagation.cpp b/src/passes/DebugLocationPropagation.cpp new file mode 100644 index 000000000..07ae53faa --- /dev/null +++ b/src/passes/DebugLocationPropagation.cpp @@ -0,0 +1,99 @@ +/* + * Copyright 2024 WebAssembly Community Group participants + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// +// DebugLocationPropagation aim to pass debug location from parents or +// previous siblings to expression which has no debug location. This is +// useful for compilers that use Binaryen API to generate WebAssembly modules. +// + +#include "pass.h" +#include "wasm-traversal.h" +#include "wasm.h" +#include <cassert> +#include <unordered_map> + +namespace wasm { + +struct DebugLocationPropagation + : WalkerPass<PostWalker<DebugLocationPropagation>> { + + // The top element of this stack is the previous sibling or parent of the + // current expression in `doPrevisit`. To maintain this invariant, expressions + // are only popped once we are done visiting their parents. + ExpressionStack expressionStack; + + using Super = WalkerPass<PostWalker<DebugLocationPropagation>>; + bool isFunctionParallel() override { return true; } + bool modifiesBinaryenIR() override { return false; } + bool requiresNonNullableLocalFixups() override { return false; } + void runOnFunction(Module* module, Function* func) override { + if (!func->debugLocations.empty()) { + Super::runOnFunction(module, func); + } + } + + Expression* getPrevious() { + if (expressionStack.empty()) { + return nullptr; + } + assert(expressionStack.size() >= 1); + return expressionStack[expressionStack.size() - 1]; + } + + static void doPreVisit(DebugLocationPropagation* self, Expression** currp) { + auto* curr = *currp; + auto& locs = self->getFunction()->debugLocations; + auto& expressionStack = self->expressionStack; + if (locs.find(curr) == locs.end()) { + // No debug location, see if we should inherit one. + if (auto* previous = self->getPrevious()) { + if (auto it = locs.find(previous); it != locs.end()) { + locs[curr] = it->second; + } + } + } + expressionStack.push_back(curr); + } + + static void doPostVisit(DebugLocationPropagation* self, Expression** currp) { + auto& exprStack = self->expressionStack; + while (exprStack.back() != *currp) { + // pop all the child expressions and keep current expression in stack. + exprStack.pop_back(); + } + // the stack should never be empty + assert(!exprStack.empty()); + } + + static void scan(DebugLocationPropagation* self, Expression** currp) { + self->pushTask(DebugLocationPropagation::doPostVisit, currp); + + PostWalker<DebugLocationPropagation>::scan(self, currp); + + self->pushTask(DebugLocationPropagation::doPreVisit, currp); + } + + std::unique_ptr<Pass> create() override { + return std::make_unique<DebugLocationPropagation>(); + } +}; + +Pass* createDebugLocationPropagationPass() { + return new DebugLocationPropagation(); +} + +} // namespace wasm |