summaryrefslogtreecommitdiff
path: root/src/passes/DuplicateImportElimination.cpp
diff options
context:
space:
mode:
authorThomas Lively <7121787+tlively@users.noreply.github.com>2021-07-01 01:56:23 +0000
committerGitHub <noreply@github.com>2021-06-30 18:56:23 -0700
commitca27f40a2f1070a16ee7c0efc18ff35d342d8027 (patch)
treeab0f2b1b731737bc409db21f677b97be16f67c0f /src/passes/DuplicateImportElimination.cpp
parent10ef52d62468aec5762742930630e882dc5e5c0b (diff)
downloadbinaryen-ca27f40a2f1070a16ee7c0efc18ff35d342d8027.tar.gz
binaryen-ca27f40a2f1070a16ee7c0efc18ff35d342d8027.tar.bz2
binaryen-ca27f40a2f1070a16ee7c0efc18ff35d342d8027.zip
Preserve Function HeapTypes (#3952)
When using nominal types, func.ref of two functions with identical signatures but different HeapTypes will yield different types. To preserve these semantics, Functions need to track their HeapTypes, not just their Signatures. This PR replaces the Signature field in Function with a HeapType field and adds new utility methods to make it almost as simple to update and query the function HeapType as it was to update and query the Function Signature.
Diffstat (limited to 'src/passes/DuplicateImportElimination.cpp')
-rw-r--r--src/passes/DuplicateImportElimination.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/passes/DuplicateImportElimination.cpp b/src/passes/DuplicateImportElimination.cpp
index b917c5fe8..a4d9065c5 100644
--- a/src/passes/DuplicateImportElimination.cpp
+++ b/src/passes/DuplicateImportElimination.cpp
@@ -41,7 +41,7 @@ struct DuplicateImportElimination : public Pass {
auto previousFunc = module->getFunction(previousName);
// It is ok to import the same thing with multiple types; we can only
// merge if the types match, of course.
- if (previousFunc->sig == func->sig) {
+ if (previousFunc->type == func->type) {
replacements[func->name] = previousName;
toRemove.push_back(func->name);
continue;