[wasm-builder] Construct module elements as unique_ptrs (#3391)

When Functions, Globals, Events, and Exports are added to a module, if they are
not already in std::unique_ptrs, they are wrapped in a new std::unique_ptr owned
by the Module. This adds an extra layer of indirection when accessing those
elements that can be avoided by allocating those elements as std::unique_ptrs.
This PR updates wasm-builder to allocate module elements via std::make_unique
rather than `new`. In the future, we should remove the raw pointer versions of
Module::add* to encourage using std::unique_ptrs more broadly.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/passes/FuncCastEmulation.cpp b/src/passes/FuncCastEmulation.cpp
index a164b4264..ba6d1d583 100644
--- a/src/passes/FuncCastEmulation.cpp
+++ b/src/passes/FuncCastEmulation.cpp
@@ -209,12 +209,12 @@ private:
     for (Index i = 0; i < NUM_PARAMS; i++) {
       thunkParams.push_back(Type::i64);
     }
-    auto* thunkFunc =
+    auto thunkFunc =
       builder.makeFunction(thunk,
                            Signature(Type(thunkParams), Type::i64),
                            {}, // no vars
                            toABI(call, module));
-    module->addFunction(thunkFunc);
+    module->addFunction(std::move(thunkFunc));
     return thunk;
   }
 };