diff options
| author | Alon Zakai <azakai@google.com> | 2021-09-23 12:36:17 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-23 12:36:17 -0700 |
| commit | 675295888609a688ee81dc9ad2024169da5aa7ed (patch) | |
| tree | 796dc5d72867300f97ab234e40729ae6b7db2875 /src/passes/Heap2Local.cpp | |
| parent | 6d46b436b54bdae040a64bd9dafb01a7f53a8233 (diff) | |
| download | binaryen-675295888609a688ee81dc9ad2024169da5aa7ed.tar.gz binaryen-675295888609a688ee81dc9ad2024169da5aa7ed.tar.bz2 binaryen-675295888609a688ee81dc9ad2024169da5aa7ed.zip | |
[Wasm GC] Implement static (rtt-free) StructNew, ArrayNew, ArrayInit (#4172)
See #4149
This modifies the test added in #4163 which used static casts on
dynamically-created structs and arrays. That was technically not
valid (as we won't want users to "mix" the two forms). This makes that
test 100% static, which both fixes the test and gives test coverage
to the new instructions added here.
Diffstat (limited to 'src/passes/Heap2Local.cpp')
| -rw-r--r-- | src/passes/Heap2Local.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/passes/Heap2Local.cpp b/src/passes/Heap2Local.cpp index f2846671c..796e0fa05 100644 --- a/src/passes/Heap2Local.cpp +++ b/src/passes/Heap2Local.cpp @@ -402,7 +402,9 @@ struct Heap2LocalOptimizer { } // Drop the RTT (as it may have side effects; leave it to other passes). - contents.push_back(builder.makeDrop(allocation->rtt)); + if (allocation->rtt) { + contents.push_back(builder.makeDrop(allocation->rtt)); + } // Replace the allocation with a null reference. This changes the type // from non-nullable to nullable, but as we optimize away the code that // the allocation reaches, we will handle that. |