summaryrefslogtreecommitdiff
path: root/src/passes/OptimizeInstructions.cpp
diff options
context:
space:
mode:
authorAlon Zakai (kripken) <alonzakai@gmail.com>2017-07-31 13:39:46 -0700
committerAlon Zakai (kripken) <alonzakai@gmail.com>2017-07-31 13:39:46 -0700
commitbfdbc0c3f6a835231b218a60ddd6b52f7e9affed (patch)
tree33c7f9e53bf6c52b1eca1b9b6f234a6d184aaf56 /src/passes/OptimizeInstructions.cpp
parent4aa3463a6b98e41070d03ddbe60e689537b02b59 (diff)
downloadbinaryen-bfdbc0c3f6a835231b218a60ddd6b52f7e9affed.tar.gz
binaryen-bfdbc0c3f6a835231b218a60ddd6b52f7e9affed.tar.bz2
binaryen-bfdbc0c3f6a835231b218a60ddd6b52f7e9affed.zip
review comments
Diffstat (limited to 'src/passes/OptimizeInstructions.cpp')
-rw-r--r--src/passes/OptimizeInstructions.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/passes/OptimizeInstructions.cpp b/src/passes/OptimizeInstructions.cpp
index 6179833b8..4fd7cbe8d 100644
--- a/src/passes/OptimizeInstructions.cpp
+++ b/src/passes/OptimizeInstructions.cpp
@@ -884,15 +884,15 @@ private:
if (!Properties::emitsBoolean(left) || !Properties::emitsBoolean(right)) return nullptr;
auto leftEffects = EffectAnalyzer(getPassOptions(), left);
auto rightEffects = EffectAnalyzer(getPassOptions(), right);
- auto leftSideEffects = leftEffects.hasSideEffects();
- auto rightSideEffects = rightEffects.hasSideEffects();
- if (leftSideEffects && rightSideEffects) return nullptr; // both must execute
+ auto leftHasSideEffects = leftEffects.hasSideEffects();
+ auto rightHasSideEffects = rightEffects.hasSideEffects();
+ if (leftHasSideEffects && rightHasSideEffects) return nullptr; // both must execute
// canonicalize with side effects, if any, happening on the left
- if (rightSideEffects) {
+ if (rightHasSideEffects) {
if (CostAnalyzer(left).cost < MIN_COST) return nullptr; // avoidable code is too cheap
if (leftEffects.invalidates(rightEffects)) return nullptr; // cannot reorder
std::swap(left, right);
- } else if (leftSideEffects) {
+ } else if (leftHasSideEffects) {
if (CostAnalyzer(right).cost < MIN_COST) return nullptr; // avoidable code is too cheap
} else {
// no side effects, reorder based on cost estimation