Revert "Stop propagating/inlining string constants (#6234)" (#6258)

This reverts commit 9090ce56fcc67e15005aeedc59c6bc6773220f11.

This has the effect of once more propagating string constants from
globals to other places (and from non-globals too), which is useful
for various optimizations even if it isn't useful in the final output.
To fix the final output problem, #6257 added a pass that is run at the
end to collect string.const to globals, which allows us to once more
propagate strings in the optimizer, now without a downside.

1 files changed, 2 insertions, 4 deletions

diff --git a/src/passes/Precompute.cpp b/src/passes/Precompute.cpp
index 89e618ab3..5baf2331f 100644
--- a/src/passes/Precompute.cpp
+++ b/src/passes/Precompute.cpp
@@ -799,11 +799,9 @@ private:
     if (type.isFunction()) {
       return true;
     }
-    // We can emit a StringConst for a string constant in principle, but we do
-    // not want to as that might cause more allocations to happen. See similar
-    // code in SimplifyGlobals.
+    // We can emit a StringConst for a string constant.
     if (type.isString()) {
-      return false;
+      return true;
     }
     // All other reference types cannot be precomputed. Even an immutable GC
     // reference is not currently something this pass can handle, as it will