diff options
| author | Thomas Lively <tlively@google.com> | 2022-09-30 18:17:45 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-30 23:17:45 +0000 |
| commit | 2055ea3fd0391c1abb92cdec54f32274dc7fd971 (patch) | |
| tree | 2d9ccaae076b065373b1507d75bc3886232363ec /src/passes/ReReloop.cpp | |
| parent | 62d056f889d4b94562a104e2fcad318857550d5b (diff) | |
| download | binaryen-2055ea3fd0391c1abb92cdec54f32274dc7fd971.tar.gz binaryen-2055ea3fd0391c1abb92cdec54f32274dc7fd971.tar.bz2 binaryen-2055ea3fd0391c1abb92cdec54f32274dc7fd971.zip | |
Refactor interaction between Pass and PassRunner (#5093)
Previously only WalkerPasses had access to the `getPassRunner` and
`getPassOptions` methods. Move those methods to `Pass` so all passes can use
them. As a result, the `PassRunner` passed to `Pass::run` and
`Pass::runOnFunction` is no longer necessary, so remove it.
Also update `Pass::create` to return a unique_ptr, which is more efficient than
having it return a raw pointer only to have the `PassRunner` wrap that raw
pointer in a `unique_ptr`.
Delete the unused template `PassRunner::getLast()`, which looks like it was
intended to enable retrieving previous analyses and has been in the code base
since 2015 but is not implemented anywhere.
Diffstat (limited to 'src/passes/ReReloop.cpp')
| -rw-r--r-- | src/passes/ReReloop.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/passes/ReReloop.cpp b/src/passes/ReReloop.cpp index 4499bb07b..9fef75367 100644 --- a/src/passes/ReReloop.cpp +++ b/src/passes/ReReloop.cpp @@ -36,7 +36,9 @@ namespace wasm { struct ReReloop final : public Pass { bool isFunctionParallel() override { return true; } - Pass* create() override { return new ReReloop; } + std::unique_ptr<Pass> create() override { + return std::make_unique<ReReloop>(); + } std::unique_ptr<CFG::Relooper> relooper; std::unique_ptr<Builder> builder; @@ -291,9 +293,7 @@ struct ReReloop final : public Pass { // TODO: optimize with this? } - void runOnFunction(PassRunner* runner, - Module* module, - Function* function) override { + void runOnFunction(Module* module, Function* function) override { Flat::verifyFlatness(function); // since control flow is flattened, this is pretty simple |