Determinism fix for SSA pass (#1841)

We iterated over a set. Instead, iterate over the relevant items in their order in the IR.

1 files changed, 6 insertions, 7 deletions

diff --git a/src/passes/SSAify.cpp b/src/passes/SSAify.cpp
index 35432d9eb..1e6668638 100644
--- a/src/passes/SSAify.cpp
+++ b/src/passes/SSAify.cpp
@@ -34,6 +34,7 @@
 #include "pass.h"
 #include "wasm-builder.h"
 #include "support/permutations.h"
+#include "ir/find_all.h"
 #include "ir/literal-utils.h"
 #include "ir/local-graph.h"
 
@@ -59,19 +60,17 @@ struct SSAify : public Pass {
     func = func_;
     LocalGraph graph(func);
     // create new local indexes, one for each set
-    createNewIndexes(graph);
+    createNewIndexes();
     // we now know the sets for each get, and can compute get indexes and handle phis
     computeGetsAndPhis(graph);
     // add prepends to function
     addPrepends();
   }
 
-  void createNewIndexes(LocalGraph& graph) {
-    for (auto& pair : graph.locations) {
-      auto* curr = pair.first;
-      if (auto* set = curr->dynCast<SetLocal>()) {
-        set->index = addLocal(func->getLocalType(set->index));
-      }
+  void createNewIndexes() {
+    FindAll<SetLocal> sets(func->body);
+    for (auto* set : sets.list) {
+      set->index = addLocal(func->getLocalType(set->index));
     }
   }