summaryrefslogtreecommitdiff
path: root/src/passes/SetGlobals.cpp
diff options
context:
space:
mode:
authorThomas Lively <tlively@google.com>2022-09-30 18:17:45 -0500
committerGitHub <noreply@github.com>2022-09-30 23:17:45 +0000
commit2055ea3fd0391c1abb92cdec54f32274dc7fd971 (patch)
tree2d9ccaae076b065373b1507d75bc3886232363ec /src/passes/SetGlobals.cpp
parent62d056f889d4b94562a104e2fcad318857550d5b (diff)
downloadbinaryen-2055ea3fd0391c1abb92cdec54f32274dc7fd971.tar.gz
binaryen-2055ea3fd0391c1abb92cdec54f32274dc7fd971.tar.bz2
binaryen-2055ea3fd0391c1abb92cdec54f32274dc7fd971.zip
Refactor interaction between Pass and PassRunner (#5093)
Previously only WalkerPasses had access to the `getPassRunner` and `getPassOptions` methods. Move those methods to `Pass` so all passes can use them. As a result, the `PassRunner` passed to `Pass::run` and `Pass::runOnFunction` is no longer necessary, so remove it. Also update `Pass::create` to return a unique_ptr, which is more efficient than having it return a raw pointer only to have the `PassRunner` wrap that raw pointer in a `unique_ptr`. Delete the unused template `PassRunner::getLast()`, which looks like it was intended to enable retrieving previous analyses and has been in the code base since 2015 but is not implemented anywhere.
Diffstat (limited to 'src/passes/SetGlobals.cpp')
-rw-r--r--src/passes/SetGlobals.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/passes/SetGlobals.cpp b/src/passes/SetGlobals.cpp
index 4109eb69b..58a82a50b 100644
--- a/src/passes/SetGlobals.cpp
+++ b/src/passes/SetGlobals.cpp
@@ -28,8 +28,8 @@ struct SetGlobals : public Pass {
// Only modifies globals.
bool requiresNonNullableLocalFixups() override { return false; }
- void run(PassRunner* runner, Module* module) override {
- Name input = runner->options.getArgument(
+ void run(Module* module) override {
+ Name input = getPassRunner()->options.getArgument(
"set-globals",
"SetGlobals usage: wasm-opt --pass-arg=set-globals@x=y,z=w");