diff options
| author | Thomas Lively <7121787+tlively@users.noreply.github.com> | 2022-08-04 17:05:54 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-05 00:05:54 +0000 |
| commit | 6759371b5239efa3daa9d988455abdd14a8b18ca (patch) | |
| tree | 0c3a3e371ed742bdbd790f7344ec86e8536bc167 /src/passes/StackIR.cpp | |
| parent | 9534e6927c41f4a6a5d06d58d00c271c9f066e9a (diff) | |
| download | binaryen-6759371b5239efa3daa9d988455abdd14a8b18ca.tar.gz binaryen-6759371b5239efa3daa9d988455abdd14a8b18ca.tar.bz2 binaryen-6759371b5239efa3daa9d988455abdd14a8b18ca.zip | |
Remove RTTs (#4848)
RTTs were removed from the GC spec and if they are added back in in the future,
they will be heap types rather than value types as in our implementation.
Updating our implementation to have RTTs be heap types would have been more work
than deleting them for questionable benefit since we don't know how long it will
be before they are specced again.
Diffstat (limited to 'src/passes/StackIR.cpp')
| -rw-r--r-- | src/passes/StackIR.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/passes/StackIR.cpp b/src/passes/StackIR.cpp index a3d9442bf..84e19428d 100644 --- a/src/passes/StackIR.cpp +++ b/src/passes/StackIR.cpp @@ -72,7 +72,7 @@ public: // Removing unneeded blocks is dangerous with GC, as if we do this: // // (call - // (rtt) + // (struct.new) // (block // (nop) // (i32) @@ -80,7 +80,7 @@ public: // ) // === remove inner block ==> // (call - // (rtt) + // (struct.new) // (nop) // (i32) // ) @@ -90,7 +90,7 @@ public: // (call // (block // (local.set - // (rtt) + // (struct.new) // ) // (nop) // (local.get) @@ -98,7 +98,9 @@ public: // (i32) // ) // - // However, that is not valid as an rtt cannot be set to a local. + // However, that is not valid as an non-nullable reference cannot be set to + // a local. TODO: double check that this is still true now that we don't + // have RTTs. if (!features.hasGC()) { removeUnneededBlocks(); } |