diff options
| author | Alon Zakai <azakai@google.com> | 2024-04-24 11:04:42 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-24 11:04:42 -0700 |
| commit | 1c977ba820e7d1027c5f1c457ea350b7220b789d (patch) | |
| tree | 826be355375ecfc001432c33b435a9e30d6e3122 /src/passes/StringLowering.cpp | |
| parent | eb566054dd246c15997c12bb8bb0b0c1b47ed5a5 (diff) | |
| download | binaryen-1c977ba820e7d1027c5f1c457ea350b7220b789d.tar.gz binaryen-1c977ba820e7d1027c5f1c457ea350b7220b789d.tar.bz2 binaryen-1c977ba820e7d1027c5f1c457ea350b7220b789d.zip | |
[Strings] Do not reuse mutable globals in StringGathering (#6531)
We were reusing mutable globals in StringGathering, which meant
that we'd use a global to represent a particular string but if it was mutated
then it could contain a different string during execution.
Diffstat (limited to 'src/passes/StringLowering.cpp')
| -rw-r--r-- | src/passes/StringLowering.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/passes/StringLowering.cpp b/src/passes/StringLowering.cpp index dd7428546..5b5a5b551 100644 --- a/src/passes/StringLowering.cpp +++ b/src/passes/StringLowering.cpp @@ -126,7 +126,8 @@ struct StringGathering : public Pass { // Find globals to reuse (see comment on stringPtrsToPreserve for context). for (auto& global : module->globals) { - if (global->type == nnstringref && !global->imported()) { + if (global->type == nnstringref && !global->imported() && + !global->mutable_) { if (auto* stringConst = global->init->dynCast<StringConst>()) { auto& globalName = stringToGlobalName[stringConst->string]; if (!globalName.is()) { |